From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933889AbbHDNbd (ORCPT ); Tue, 4 Aug 2015 09:31:33 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34721 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933124AbbHDNbc (ORCPT ); Tue, 4 Aug 2015 09:31:32 -0400 Date: Tue, 4 Aug 2015 15:31:30 +0200 From: Michal Hocko To: Ulrich Obergfell Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dzickus@redhat.com, atomlin@redhat.com, jolsa@kernel.org, eranian@google.com, cmetcalf@ezchip.com, fweisbec@gmail.com Subject: Re: [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug() Message-ID: <20150804133129.GF28571@dhcp22.suse.cz> References: <1438433365-2979-1-git-send-email-uobergfe@redhat.com> <1438433365-2979-5-git-send-email-uobergfe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438433365-2979-5-git-send-email-uobergfe@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 01-08-15 14:49:25, Ulrich Obergfell wrote: [...] > @@ -3368,7 +3368,10 @@ static __init int fixup_ht_bug(void) > return 0; > } > > - watchdog_nmi_disable_all(); > + if (watchdog_suspend() != 0) { > + pr_info("failed to disable PMU erratum BJ122, BV98, HSD29 workaround\n"); > + return 0; > + } Is this really worth reporting to the log? What is an admin supposed to do about it? Ok, so kthread_park fails only when the kernel thread has already exited. Can this ever happen during this call path? -- Michal Hocko SUSE Labs