From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbHDQAh (ORCPT ); Tue, 4 Aug 2015 12:00:37 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:53546 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbbHDQAf (ORCPT ); Tue, 4 Aug 2015 12:00:35 -0400 Date: Tue, 4 Aug 2015 11:00:28 -0500 From: Felipe Balbi To: Kishon Vijay Abraham I CC: , , , , , , , , Subject: Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Message-ID: <20150804160028.GG23659@saruman.tx.rr.com> Reply-To: References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-2-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xs+9IvWevLaxKUtW" Content-Disposition: inline In-Reply-To: <1438701646-7876-2-git-send-email-kishon@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xs+9IvWevLaxKUtW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Add separate functions for pll, > clocks and syscon to make ti_pipe3_probe clean. >=20 > Signed-off-by: Kishon Vijay Abraham I I think this needs to be splitted into smaller patches. Seems like the very first patch would be to introduce a local struct device pointer to be used. Than add each and every new function on their own patch. This will help big time making your refactoring a lot clearer and, should anything go wrong, we can atomically revert a specific change, instead of loosing the entire refactor. --=20 balbi --xs+9IvWevLaxKUtW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVwOGbAAoJEIaOsuA1yqREHbUP/i3RO4hl2GJzeN8vL6Edwkdm +jhJ1GKYWUX7KQEZ74HKKG1oAORT3R095ruJtszq0nrbEhVyM/FaC8TwvZFhbtxK 4F7Id9kxjrQ1njFN87n4WfzUQlAAO2IuqFdSh+qKDAj2zTNYhMO8mcqQdLPYs3Kj k4ew8RXsS8toHqpWnmH7L5w30WjiqOo8z3UUaVm3Zogdw6pNnYYidqoqBX8ZC42z 62LDHSmZ8CP7P4iAFr8kZSAXp9SZCamrVRTy2o8q5LpyduWCxIvdAmOpZcijlDlP fYkZD4yP/1G03b9Fis+BOcXmXZKPJRYtZKMEer0zeVgxA6fP3XqUxaepRHJA4PDs 1xhHjuczw3e1wa3k8ZMTNjcFn4F+soMgIbAR4Y3QjIVXz2d7E7EMyWWcT2Io13zF ceaISmghmdZcLnhQDOp27p4tPgeFWVjkG/4bgyiNUt847wnhhVZtfUx3pDFDIvEV ct+Q2TpGVeHt0+pnMOPAlS5STN6um/FI9/zuGhGdOAqTVXV3gxNrNq7bhH6xwd5L jbl8kqjR/Rf5GWiaWlTnibcv+TZNCYfN3z/RfiP3QcELcIs+ejbucGbI1qB1Fqnm gfn6REfySExuh5Ppy2F67qETDRwawNNRf9WiwsMrg/zdRDs6fA9zghrjrJhiVWt1 dARmvr2TNn3123P+TSeN =Vv01 -----END PGP SIGNATURE----- --xs+9IvWevLaxKUtW--