From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbbHDQGj (ORCPT ); Tue, 4 Aug 2015 12:06:39 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:53856 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbbHDQGh (ORCPT ); Tue, 4 Aug 2015 12:06:37 -0400 Date: Tue, 4 Aug 2015 11:06:31 -0500 From: Felipe Balbi To: Kishon Vijay Abraham I CC: , , , , , , , , Subject: Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe Message-ID: <20150804160631.GH23659@saruman.tx.rr.com> Reply-To: References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-3-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TKYYegg/GYAC5JIZ" Content-Disposition: inline In-Reply-To: <1438701646-7876-3-git-send-email-kishon@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TKYYegg/GYAC5JIZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to pow= er there is a slight functional change. You moved PHY power off from before to after pm_runtime_enable(), clk_prepare_enable() and creation of the PHY device. That ought to have a slight impact on how the driver behaves. --=20 balbi --TKYYegg/GYAC5JIZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVwOMHAAoJEIaOsuA1yqRECdkP/RLmFLYqXu40f37ywImNtAbp e43HP8Gr5yL65G/nZfJ4MRgTKtTd544925znvKmTgJXHRrfUK5YyvotBVER53/4A lxBNxA2Fg9y83M5Htrbwg360mf1go0YDllhG9H3QN/+/fA+up2Q4kGi7/mB/skuS EzlU/W6Hvwl0CjVtehufAzBu32QJGnIekGt+CQkbCiKCAYGA07TA1XHaiXzV+MRP nmRlV95oEf7yvkODThEz2CY+BOo45B9t1cFWphA0twd3Okwvj3OC48onDYXZqeDX Z/B3bOBeZnpWket1/bJOzXnFdtSTUpzHHXWiZwDzeLG2DbVlO/WlLHYFVSmFqEPE wlQt3dOzlBZHp7ud1tZ1ClPSs2JTH+7CTI7oJvnanFIGctS3mOxk0sWXzNg8F59/ zCCIBF7x33B9jSfONN7eI4tdcZYT3RafB5/ED+FsAF/tNduO8RRkBTIMYDaQSkEr 6hz/wdcACk+civZbyq6YHSeulaOkPRPa1uqflUotRnGA3i0psjDbaTifbo6mcWzf 6zbbc3eeitYfnRlQUU844vSQVtkju42Hjlz4GSuwsUfh1HH2R5Efi5qyDDNGY3fg qGHUWzAMCfcNyhpKgdrvAFVGJEX/6tu/5SzdcNIBxhseTGCsFN5uWk1uwtMPgiGX 1tELllij30tX1OX8y+N3 =pwLB -----END PGP SIGNATURE----- --TKYYegg/GYAC5JIZ--