From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
Date: Tue, 4 Aug 2015 11:37:53 -0700 [thread overview]
Message-ID: <20150804183753.GB69437@jaegeuk-mac02.hsd1.ca.comcast.net> (raw)
In-Reply-To: <011a01d0c9e1$8ead48d0$ac07da70$@samsung.com>
On Wed, Jul 29, 2015 at 05:32:00PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > Sent: Tuesday, July 28, 2015 11:57 PM
> > To: Chao Yu
> > Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> > Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
> >
> > On Tue, Jul 28, 2015 at 06:25:26PM +0800, Chao Yu wrote:
> > > Hi Jaegeuk,
> > >
> > > > -----Original Message-----
> > > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > > > Sent: Sunday, July 26, 2015 8:21 AM
> > > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > > > linux-f2fs-devel@lists.sourceforge.net
> > > > Cc: Jaegeuk Kim
> > > > Subject: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
> > > >
> > > > This patch adds to handle error cases in commit_inmem_pages.
> > > > If an error occurs, it stops to write the pages and return the error right
> > > > away.
> > > >
> > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > > > ---
> > > > fs/f2fs/f2fs.h | 2 +-
> > > > fs/f2fs/file.c | 6 ++++--
> > > > fs/f2fs/segment.c | 10 ++++++++--
> > > > 3 files changed, 13 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > > > index e73f2e2..58b05b5 100644
> > > > --- a/fs/f2fs/f2fs.h
> > > > +++ b/fs/f2fs/f2fs.h
> > > > @@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);
> > > > * segment.c
> > > > */
> > > > void register_inmem_page(struct inode *, struct page *);
> > > > -void commit_inmem_pages(struct inode *, bool);
> > > > +int commit_inmem_pages(struct inode *, bool);
> > > > void f2fs_balance_fs(struct f2fs_sb_info *);
> > > > void f2fs_balance_fs_bg(struct f2fs_sb_info *);
> > > > int f2fs_issue_flush(struct f2fs_sb_info *);
> > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > > index 25d1a2f..a2b3656 100644
> > > > --- a/fs/f2fs/file.c
> > > > +++ b/fs/f2fs/file.c
> > > > @@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
> > > >
> > > > if (f2fs_is_atomic_file(inode)) {
> > > > clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
> > > > - commit_inmem_pages(inode, false);
> > > > + ret = commit_inmem_pages(inode, false);
> > > > + if (ret)
> > > > + return ret;
>
> It looks we forget to call mnt_drop_write_file before return.
Oh, yes. :)
I fixed that.
Thanks,
>
> [snip]
>
> > This entry is not removed from the list.
> > So, after failure, the abort path will put the page and remove it from the list.
>
> Oh, you're right, thanks for your explanation! :)
>
> Thanks,
next prev parent reply other threads:[~2015-08-04 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 0:21 [PATCH 1/2] f2fs: call set_page_dirty to attach i_wb for cgroup Jaegeuk Kim
2015-07-26 0:21 ` [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages Jaegeuk Kim
2015-07-28 10:25 ` [f2fs-dev] " Chao Yu
2015-07-28 15:57 ` Jaegeuk Kim
2015-07-29 9:32 ` Chao Yu
2015-08-04 18:37 ` Jaegeuk Kim [this message]
2015-07-28 10:29 ` [f2fs-dev] [PATCH 1/2] f2fs: call set_page_dirty to attach i_wb for cgroup Chao Yu
2015-07-28 15:32 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804183753.GB69437@jaegeuk-mac02.hsd1.ca.comcast.net \
--to=jaegeuk@kernel.org \
--cc=chao2.yu@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®