From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbbHFATY (ORCPT ); Wed, 5 Aug 2015 20:19:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37067 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754607AbbHFATT (ORCPT ); Wed, 5 Aug 2015 20:19:19 -0400 Date: Wed, 05 Aug 2015 17:32:33 -0700 (PDT) Message-Id: <20150805.173233.539752020022715092.davem@davemloft.net> To: Liviu.Dudau@arm.com Cc: mlindner@marvell.com, stephen@networkplumber.org, ryan.harkin@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address From: David Miller In-Reply-To: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com> References: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Aug 2015 17:19:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liviu Dudau Date: Wed, 5 Aug 2015 16:50:54 +0100 > For designs where EEPROMs are not connected to PCI Yukon2 > chips we need to get the MAC address from the firmware. > Add a module parameter called 'mac_address' for this. It > will be used if no DT node can be found and the B2_MAC > register holds an invalid value. > > Signed-off-by: Liviu Dudau Sorry, such module options are absolutely not allowed. If an invalid MAC is present, it should be set to a random one via eth_random_addr().