From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbbHEQKV (ORCPT ); Wed, 5 Aug 2015 12:10:21 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:35248 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753072AbbHEQKR (ORCPT ); Wed, 5 Aug 2015 12:10:17 -0400 Date: Wed, 5 Aug 2015 18:10:11 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Arnaldo Carvalho de Melo , Vince Weaver , Stephane Eranian Subject: Re: [PATCH RFC v1 1/4] perf: Introduce extended syscall error reporting Message-ID: <20150805161011.GO19282@twins.programming.kicks-ass.net> References: <1437738359-23920-1-git-send-email-alexander.shishkin@linux.intel.com> <1437738359-23920-2-git-send-email-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437738359-23920-2-git-send-email-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 02:45:56PM +0300, Alexander Shishkin wrote: > @@ -3890,7 +3958,7 @@ perf_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) > ret = perf_read_hw(event, buf, count); > perf_event_ctx_unlock(event, ctx); > > - return ret; > + return perf_error_report(&event->attr, ret); > } > > static unsigned int perf_poll(struct file *file, poll_table *wait) > @@ -4103,7 +4171,7 @@ static long perf_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > ret = _perf_ioctl(event, cmd, arg); > perf_event_ctx_unlock(event, ctx); > > - return ret; > + return perf_error_report(&event->attr, ret); > } > > #ifdef CONFIG_COMPAT Oooh, shiny.. So not only does it work for SYSCALL time fails, it keeps the pointer about and reports all subsequent fails in there too.