From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbbHFWtQ (ORCPT ); Thu, 6 Aug 2015 18:49:16 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43957 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbHFWtO (ORCPT ); Thu, 6 Aug 2015 18:49:14 -0400 Date: Thu, 06 Aug 2015 15:49:10 -0700 (PDT) Message-Id: <20150806.154910.1261240005857312043.davem@davemloft.net> To: mst@redhat.com Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com Subject: Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST From: David Miller In-Reply-To: <20150806161042-mutt-send-email-mst@redhat.com> References: <1438742044-31064-1-git-send-email-jasowang@redhat.com> <20150806161042-mutt-send-email-mst@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Aug 2015 15:49:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Thu, 6 Aug 2015 16:13:11 +0300 > On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote: >> virtio declares support for NETIF_F_FRAGLIST, but assumes >> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't >> always true with a fraglist. >> >> A longer fraglist in the skb will make the call to skb_to_sgvec overflow >> the sg array, leading to memory corruption. >> >> Drop NETIF_F_FRAGLIST so we only get what we can handle. >> >> Cc: Michael S. Tsirkin >> Signed-off-by: Jason Wang > > I noticed only now that this didn't Cc Dave, so of course it's > not applied. CC:'ing me isn't the requirement. CC:'ing netdev is, which he did. If you check patchwork, it's there in the queue. I'm just behind and heavily backlogged because I've been working on other things.