From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning
Date: Thu, 6 Aug 2015 10:43:29 +0100 [thread overview]
Message-ID: <20150806094329.GQ20873@sirena.org.uk> (raw)
In-Reply-To: <1438790528-4435-1-git-send-email-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Wed, Aug 05, 2015 at 05:02:08PM +0100, Srinivas Kandagatla wrote:
> A recursive lockdep warning occurs if you call regulator_set_voltage()
> on a load switches that are modelled as regulators with a parent supply as
> there is no nesting annotation for the rdev->mutex.
> To avoid this warning, use the unlocked version of the get_voltage().
No, just completely removing the locking is broken - the locking is
there for a reason! This needs some lockdep dance, either something
like what we have for regmaps with a class per regulator or something
more fancy but whatever's going on just hacking out locking to shut up
warnings from lockdep is clearly not a good idea.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-06 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 16:02 Srinivas Kandagatla
2015-08-06 1:39 ` Krzysztof Kozlowski
2015-08-06 7:29 ` Srinivas Kandagatla
2015-08-06 7:35 ` Krzysztof Kozlowski
2015-08-06 7:53 ` Krzysztof Kozlowski
2015-08-06 9:43 ` Mark Brown [this message]
2015-08-06 11:01 ` Srinivas Kandagatla
2015-08-06 11:40 ` Mark Brown
2015-08-06 11:49 ` Srinivas Kandagatla
2015-08-07 14:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806094329.GQ20873@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®