From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbbHFQAK (ORCPT ); Thu, 6 Aug 2015 12:00:10 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34255 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753988AbbHFQAI (ORCPT ); Thu, 6 Aug 2015 12:00:08 -0400 Date: Thu, 6 Aug 2015 21:29:44 +0530 From: Chandra Gorentla To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Chandra S Gorentla Subject: Re: [PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line Message-ID: <20150806155939.GA18397@gcs-HP-Compaq-nx6320> References: <1438792917-9817-1-git-send-email-csgorentla@gmail.com> <1438792917-9817-2-git-send-email-csgorentla@gmail.com> <1438792917-9817-3-git-send-email-csgorentla@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438792917-9817-3-git-send-email-csgorentla@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 10:11:56PM +0530, Chandra S Gorentla wrote: > Moved the opening brace of code blocks to the previous lines. This > fixes the checkpatch.pl error - "that open brace { should be on the > previous line". > > Signed-off-by: Chandra S Gorentla > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index c2ef46f..779ec5a 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > @@ -1205,8 +1205,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k > > > > - if (!pairwise) > - { > + if (!pairwise) { > if (params->cipher == WLAN_CIPHER_SUITE_TKIP) > u8gmode = ENCRYPT_ENABLED | WPA | TKIP; > else > @@ -1304,8 +1303,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k > > { > u8mode = 0; > - if (!pairwise) > - { > + if (!pairwise) { > if (params->key_len > 16 && params->cipher == WLAN_CIPHER_SUITE_TKIP) { > /* swap the tx mic by rx mic */ > pu8RxMic = params->key + 24; > @@ -1531,8 +1529,7 @@ static int WILC_WFI_get_key(struct wiphy *wiphy, struct net_device *netdev, u8 k > priv = wiphy_priv(wiphy); > > > - if (!pairwise) > - { > + if (!pairwise) { > PRINT_D(CFG80211_DBG, "Getting group key idx: %x\n", key_index); > > key_params.key = priv->wilc_gtk[key_index]->key; > -- > 2.5.0 > Hello Greg, I sent 3 patches in this series. The subject lines of other 2 are - [PATCH v3 3/3] drivers: staging: wilc1000: remove space after '(' [PATCH v3 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions These two patches (1/3 and 3/3) were accepted but not the patch (2/3) in this mail. Any reason for not accepting? Is any thing wrong with this patch - 2/3? If so, I can correct and send again. Thanks, chandra