From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756035AbbHFSdb (ORCPT ); Thu, 6 Aug 2015 14:33:31 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59729 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014AbbHFSd3 (ORCPT ); Thu, 6 Aug 2015 14:33:29 -0400 Date: Thu, 6 Aug 2015 19:33:22 +0100 From: Mark Brown To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, support.opensource@diasemi.com Message-ID: <20150806183322.GF20873@sirena.org.uk> References: <1438879104-13081-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qYz+xqWFH0CdBh3r" Content-Disposition: inline In-Reply-To: <1438879104-13081-1-git-send-email-p.zabel@pengutronix.de> X-Cookie: Please take note: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qYz+xqWFH0CdBh3r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 06, 2015 at 06:38:24PM +0200, Philipp Zabel wrote: > This allows to set the regulator-ramp-delay in the device tree. > @@ -433,6 +433,7 @@ static struct regulator_ops da9063_buck_ops = { > .is_enabled = regulator_is_enabled_regmap, > .get_voltage_sel = regulator_get_voltage_sel_regmap, > .set_voltage_sel = regulator_set_voltage_sel_regmap, > + .set_voltage_time_sel = regulator_set_voltage_time_sel, > .list_voltage = regulator_list_voltage_linear, > .set_current_limit = da9063_set_current_limit, > .get_current_limit = da9063_get_current_limit, This doesn't seem right - we shouldn't need to manually add this to every device to get the generic property to work. Instead we ought to just do this by default if there's nothing defined in the driver and we see that a value was provided by DT. --qYz+xqWFH0CdBh3r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVw6hxAAoJECTWi3JdVIfQSiEH/RJ0BOZkyrmVHyjbm29AZBIh KfJ45e8t0G5uBn4F0qO5zFssoPRl+EHp1VPH6IcrB2fq/MbBUnj7KMA4SZUISiUW rDNuvD1wTvmt8UW19kMuh0zI/2oOyVk+0v0ihF+t3DqWOBVoTJ3QIjCQtLzpYhs5 tsumY9Nkddp6ObCUAT1Uz7Q4boG46IcBNk66qNZTi0wF/PSlWwp09fYNalec7Dmj +D6SROF6MWTr7TCD6H6cZ2ATNHynVpJXinpi7rw1Ps7Q83lAnBryxvHfmzmMN0OB xksXjYc3Fve/6GLjV/fILkE3Xadylh7bZymzBnfRPVKu7DPF4lr2ubVNBOJA8Pg= =6x20 -----END PGP SIGNATURE----- --qYz+xqWFH0CdBh3r--