From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbbHGEzz (ORCPT ); Fri, 7 Aug 2015 00:55:55 -0400 Received: from mail-bn1bon0140.outbound.protection.outlook.com ([157.56.111.140]:2236 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752114AbbHGEzx (ORCPT ); Fri, 7 Aug 2015 00:55:53 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; amacapital.net; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NSP4D0-07-YP5-02 X-M-MSG: Date: Fri, 7 Aug 2015 12:46:37 +0800 From: Huang Rui To: Borislav Petkov CC: Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , , , Fengguang Wu , Aaron Lu , Tony Li , Andreas Herrmann Subject: Re: [PATCH v6 2/2] x86, mwaitt: introduce mwaitx delay with a configurable timer Message-ID: <20150807044636.GB7607@hr-slim.amd.com> References: <1438744732-1459-1-git-send-email-ray.huang@amd.com> <1438744732-1459-3-git-send-email-ray.huang@amd.com> <20150806151440.GB32064@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150806151440.GB32064@nazgul.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD016;1:PGp6oJaEtUENQY2YBA3m8AzoqF4jfR89ZChXLDMf/Ev0RnuegeulES/Gs6its4oxYRSFAZUSoILpDgNgcf++C9YRJnnKfn79NeR9puwDfNeIfTTofbcU0Ll1HMrdjO6EzBUKxXxrDUVl07C47lXKY8uwhtkmXOL1RKDgxsjJWXWFomwvi1/HjiHPqSJ3uOqeMbNYmlqic2YG/JWF6w95D9jfpK7nlYZCwndQt6j+jZRPiUq0/jo7+lGOE+g+4qAZyRKkQhmDxtXYUcgLJcbmnJJu78TRRS7A5LTbspGVA4gx4F6lfe9QU1xGc1Ru5XZLqOEPzeAqnQ+GGTCtfNOsUg== X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(428002)(164054003)(24454002)(199003)(189002)(5003600100002)(4001350100001)(4001540100001)(97736004)(23726002)(5001830100001)(5001860100001)(105586002)(106466001)(68736005)(53416004)(77096005)(92566002)(189998001)(110136002)(33656002)(46406003)(87936001)(50466002)(83506001)(62966003)(77156002)(76176999)(86362001)(54356999)(47776003)(101416001)(46102003)(2950100001)(64706001)(97756001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0201MB1497;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1497;2:q0Xo56QKrciaC6nqdU4Ige2eBnB7+3d1jFFlmX7x4SBRUg0gJTFcA8m2PM3N/RZduN4r1I7MZAQBERW6j6OBPNvQWWdS4y8Y1Lp/fqaNuRYGTqaVRd+0iLglvytP0uEHA5euXZdeIuCX0Ws3JW+RbOA3MPwtGU52IoyX6Z1Dx9M=;3:fvlpeL4x9QkKpsZw1EemI4JFKD0QyX0uXgGxxir8K7b1r11WHw0+ElshRc7tPOAyQG9l/SFvL3D6DFD9zXkWfKFx5CyRvwS/u0yA2Xdbzorv3H4GalUQ4V177v6WUdG/8f7+uJFo8ZklUIPJ2/MzLWsM9VBjk64udn1L//NSZzzVjZkSvE7zrAwTlCf4ZbGt60U5hsECkGvZWLH8AAX12Kns5maJB5UNL6R9KDEMEw1zS2IhC7DGFwdOxmivm62a;25:BwFRcUqfaG63kU5ycSkirDZLGw//GtRESvlPR7dLEfXqv+7J2Xd7srasrN0a5tWMyerYFMftHawJ6gA8P170ia+f4LjJo9N2WmEsvg40zOEJEZPSTTrIt7BgTvJO6K4Sf/77B0a9JNrFV5rZoAmPxEOnk1/ofO8GZ/yb9/Po3BlUQWO1e2lPhM2ph8YpgSuMzBV4FL/50QgRkPAfWCjoogp+c1zFug0lE/MmOCranDPrhjJCLMslk+6GFuok35nO6cnyYekPyDUWIfRZUpHclQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1497; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1497;20:Pdh2mqLzJ6vtJM6bsAOUgaKZiQv4VeYKKH3cyq6wJcL+EcDcNrXLcPv7uBhbyYoW/2IRC6G6q7YLK8/DogY1/A5H92TpTRX68byz7+aYzN/xWptkUewum0h553InKX56YuTuUoz/9oTfzjO+FW4bbttWhoqasDJFrC9SbMOyc/TFuLb7KnPe1KTvD7WQFD8rHzTunZIglhSASixjvMQKk9X+W8CDDfy1zXB2KK8dvCSjA2kJKubip8QHxtu1Htg6du7nohOB4FUU5CB9ve0EXi06FHpzQujmDFvJAxaGHtmdNU8FKUT88/7uObEou5mxIO0YszzNkvGyz/CkyXfgX9gDRnUi2Q2lkZQSdQiO2j8C5ROOk9bbxruhG4NoibF7nPfajKqaBjHoLswHKGlhChntqYiZXloAxBRCAejH1q3bTasCrWbg/dfxCDgrG7RRpsVQZ5TsjmRyJe8ELZuBG+Z6lwYbzZPhH+fqaKp8oilFf39v3myj3qPEeEIe1zB/;4:DietzW6KYHEhrR7kvCknBVopnIkNgB9oMsOjeo/N8938ptn1bsNYwArV7v+DeSmUkkh6qT6iWmcrDXSCSAMyE2JFxk/qWxNHS0rOLc1xf2SbkkHuK0W2Lo2aUw/7ttMluVbdG1SNhDCboQEOyXwNx+edUGe+vrQJYRpVbMwK1SA+juAVP1p7ZXrFS5rYA7id0ykk+Y5ng7z6kVQ64McvZG7aLvKxIJRd1CNNaoi86SpGkJIw6y83INBQxhL7xcGXg4GVzH24t7Dgle9n4dbsCVRTT8B2NmeNP57J87snwrg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR0201MB1497;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1497; X-Forefront-PRVS: 066153096A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0201MB1497;23:uhwtYtrwECIcAi+lk5EOlW3Re6agDAORuRXkCB7?= =?us-ascii?Q?0DKJmaqVVxpUOvn9gmsOpdAj4bSR84ROWl+XHLjEojpgAm7YyYUfneVVThO2?= =?us-ascii?Q?QxL0h6rfJ9iDjiQWg2I+mW0+w3eUYGUGwGD10sPKbGXTBbw/hzVTau3U4yI8?= =?us-ascii?Q?bLO/wj47odi3TRxxPtCpvinp1XxT0CNngDoLbJcGWSJEa44ktg2Qfw/bop3a?= =?us-ascii?Q?spWthtiP/TG4tlP1p4AnwdQ+GiHespSfN4+xKSCHPkH13pzJwqx7uiIOvwhg?= =?us-ascii?Q?ONvpnLd2QX5HnIJvgoUoNhPWAKEK5JJ7QP43Ykta05a06evc3pIzo2SHvFbS?= =?us-ascii?Q?ZfPFeksp7EwgbDHsGTvaL8mkeO41Tnhkaas3AEV2+vl1+o3MvLUfmTpQNvXF?= =?us-ascii?Q?sAoPY0qXhmdS1zFph7ahONI3ST+A+23NiaHOjLjypg6B0BjvYP7wtnQp+Gho?= =?us-ascii?Q?p1i1+WG8i1CnWPQqEwu5X6btwVuNSOrX2yvyY1VEh2QLl0BzcClWrBGYFGJZ?= =?us-ascii?Q?wp11aCOzgL3O5Rs6eJ/3PG2IGEsAkbEq9SCxl/DSHMOCxWJYwJ7BxIlESTZ/?= =?us-ascii?Q?/gZSKE5iDBoJrslzWgf7Hh3ZQkPP8HqhcJlHTPLQ3HLbcitoLJoOnc3qDpa6?= =?us-ascii?Q?62pzvxKROWhSUd8/aY+Ms6T+tiPSORftx1gKky5ioD/hdc4lepfpJt9kLKuN?= =?us-ascii?Q?Jo5O5D9SOLpqjJytA23emz9GAqNu5opVDwXJh/ApHbSuGRxQUCVCeSK7gMP2?= =?us-ascii?Q?po84T0b6QsMzQr0hlRGh1E92BxLzQjXUCQOu9wbYOZWRCC3ftNljTROrZWIM?= =?us-ascii?Q?0ZNugY831A+82xjRCzfnJc0CTVwS4rcObtw3K+88JAligtiY/Te9CuWFewYC?= =?us-ascii?Q?rbEj5L9+7iwQsHsOElmZabjpOmq0cxESqD4IJz3xMrP6q2O3iTosOLN5cycW?= =?us-ascii?Q?dlnXuSVDKNvCVsNw8knYKcHZ/ex2a+yxwzf7q71jQZic4ynTXE3ZPvYPR2L1?= =?us-ascii?Q?hygWBkf8R2eBzU1H/CLDNrFva+W8FfaMl+hXPUi3vxaw/sg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1497;5:qPRjve+mAIsRqs7NIPSmCF9hI2+zFECwMnc/5Qjm+9nH/ivmshgmaG7u5LP3LTUcJd4HN504lgsyPlQEBUaWTQoYQ1VL2/tjS0v2cOYBDabOAqlYE0QcGwRC9Puc86JhdeJFYKLtR/U9YUma+OhQ7w==;24:YLObyn6VHlVQgbw+IHxQvjQhnmTMjYpqGTImzhGvhDf2ooX5ekqMJo2zjrLDXeLKji/RC+oL8WOSQp2euu3C/93YTnNI1S1m47XBbreZvtA=;20:ewWpddG8drxqQAgs89YmWplus8bFRseXeWrQU7zLUj38m1ZDbwmEvZQC6UJdYTprLbNv1uNV6uRSxz88W+2mzg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2015 04:55:49.3578 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1497 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2015 at 05:14:40PM +0200, Borislav Petkov wrote: > On Wed, Aug 05, 2015 at 11:18:52AM +0800, Huang Rui wrote: > > +static void delay_mwaitx(unsigned long __loops) > > +{ > > + u32 delay, loops = __loops; > > + u64 end, start; > > Hmm, this truncates __loops in case someone wants to delay for more > than (u32)-1 TSC clocks. I guess the right thing to do is to do the > calculation with u64s and MWAITX_MAX_LOOPS will keep us within bounds. > Yes, you're right. Thanks to update. :) Thanks, Rui