From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809AbbHGGiS (ORCPT ); Fri, 7 Aug 2015 02:38:18 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58590 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbbHGGiR (ORCPT ); Fri, 7 Aug 2015 02:38:17 -0400 Date: Thu, 6 Aug 2015 23:38:16 -0700 From: Christoph Hellwig To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org, dan.j.williams@intel.com Subject: Re: [PATCH 1/6] pmem: remove indirection layer arch_has_pmem_api() Message-ID: <20150807063816.GA11543@infradead.org> References: <1438883000-9011-1-git-send-email-ross.zwisler@linux.intel.com> <1438883000-9011-2-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438883000-9011-2-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2015 at 11:43:15AM -0600, Ross Zwisler wrote: > Prior to this change arch_has_wmb_pmem() was only called by > arch_has_pmem_api(). Both arch_has_wmb_pmem() and arch_has_pmem_api() > checked to make sure that CONFIG_ARCH_HAS_PMEM_API was enabled. > > Instead, remove one extra layer of indirection and the redundant > CONFIG_ARCH_HAS_PMEM_API check, and just have arch_has_pmem_api() > call __arch_has_wmb_pmem() directly. The description here matches the codde, but not the suject line.. Reviewed-by: Christoph Hellwig with a fixed up subject line.