mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
Date: Fri, 7 Aug 2015 11:07:11 -0700	[thread overview]
Message-ID: <20150807180711.GB11113@kroah.com> (raw)
In-Reply-To: <1438969945-21092-1-git-send-email-tal.shorer@gmail.com>

On Fri, Aug 07, 2015 at 08:52:25PM +0300, Tal Shorer wrote:
> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
> 
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
> 	Errors on this port
> 
> Fix these two values to match the spec.
> 
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
>  include/linux/usb/hcd.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..6a24416 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
>  
>  /*-------------------------------------------------------------------------*/
>  
> -/* class requests from USB 3.0 hub spec, table 10-5 */
> -#define SetHubDepth		(0x3000 | HUB_SET_DEPTH)
> -#define GetPortErrorCount	(0x8000 | HUB_GET_PORT_ERR_COUNT)
> +/* class requests from USB 3.1 hub spec, table 10-7 */
> +#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
> +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)

Why did you loose the indentation?


  parent reply	other threads:[~2015-08-07 18:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAFDyS3P0rHeG9eNc4ttVx6EX18CtGj2WUi+9W+YRO3=fCvUsBQ@mail.gmail.com>
2015-08-07 17:52 ` Tal Shorer
2015-08-07 18:06   ` Greg KH
2015-08-07 18:07   ` Greg KH [this message]
2015-08-07 18:13     ` [Patch v2] " Tal Shorer
2015-08-07 18:15       ` Tal Shorer
2015-08-07 18:16     ` [Patch v3] " Tal Shorer
2015-08-07 18:40       ` Greg KH
2015-08-07 18:48         ` Tal Shorer
2015-08-07 19:30           ` Greg KH
2015-08-07 19:35             ` [Patch v4] " Tal Shorer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807180711.GB11113@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tal.shorer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®