From: Mark Brown <broonie@kernel.org>
To: Salah Triki <salah.triki@acm.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: Remove useless check
Date: Fri, 7 Aug 2015 19:27:30 +0100 [thread overview]
Message-ID: <20150807182730.GL10301@sirena.org.uk> (raw)
In-Reply-To: <1438968816-5370-1-git-send-email-salah.triki@acm.org>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Fri, Aug 07, 2015 at 06:33:36PM +0100, Salah Triki wrote:
> lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the
> return value is useless.
No, if you want to do this then you should be fixing the LZO API to
remove the returned value - if a value is being returned it's always
good practice to pay attention to that, not doing that because the
current implementation happens to have some behaviour just makes the
code more fragile if someone comes along and changes the implementation.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-07 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 17:33 Salah Triki
2015-08-07 18:27 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807182730.GL10301@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®