From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Douglas Hatch <doug.hatch@hp.com>,
Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: [PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL
Date: Sat, 8 Aug 2015 08:02:49 +0200 [thread overview]
Message-ID: <20150808060249.GT16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1439003881-17349-2-git-send-email-Waiman.Long@hp.com>
On Fri, Aug 07, 2015 at 11:17:56PM -0400, Waiman Long wrote:
> If _Q_SLOW_VAL has been set, the vCPU state must have been vcpu_hashed.
> The extra check at the end of __pv_queued_spin_unlock() is unnecessary
> and so is removed.
This is half the patch it should be.
Because if the load is not needed, then the store is not either, and
then there's the comments to update.
next prev parent reply other threads:[~2015-08-08 6:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 3:17 [PATCH v5 0/6] locking/qspinlock: Enhance pvqspinlock performance Waiman Long
2015-08-08 3:17 ` [PATCH v5 1/6] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL Waiman Long
2015-08-08 6:02 ` Peter Zijlstra [this message]
2015-08-14 2:07 ` Waiman Long
2015-08-08 3:17 ` [PATCH v5 2/6] locking/pvqspinlock: Add pending bit support Waiman Long
2015-08-08 3:17 ` [PATCH v5 3/6] locking/pvqspinlock: Collect slowpath lock statistics Waiman Long
2015-08-08 3:17 ` [PATCH v5 4/6] locking/pvqspinlock, x86: Optimize PV unlock code path Waiman Long
2015-08-08 3:18 ` [PATCH v5 5/6] locking/pvqspinlock: Allow vCPUs kick-ahead Waiman Long
2015-08-08 3:18 ` [PATCH v5 6/6] locking/pvqspinlock: Queue node adaptive spinning Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808060249.GT16853@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Waiman.Long@hp.com \
--cc=dave@stgolabs.net \
--cc=doug.hatch@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome