From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585AbbHIJe3 (ORCPT ); Sun, 9 Aug 2015 05:34:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51043 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754452AbbHIJe2 (ORCPT ); Sun, 9 Aug 2015 05:34:28 -0400 Date: Sun, 9 Aug 2015 11:34:25 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern Subject: Re: [PATCH 2/2] perf evlist: Be more specific on -F/--freq Message-ID: <20150809093425.GC17069@krava.brq.redhat.com> References: <1439102724-14079-1-git-send-email-namhyung@kernel.org> <1439102724-14079-2-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439102724-14079-2-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 09, 2015 at 03:45:24PM +0900, Namhyung Kim wrote: > Currently perf evlist -F shows the number as if it's always sampling > frequency. But we now support per-event freq/period settings. So it'd > better to show more detailed info whether it's freq or period. > > $ perf record -e 'cpu/config=1/,cpu/config=2,period=300000/' sleep 1 > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.017 MB perf.data ] > > $ perf evlist -F > cpu/config=1/: sample_freq=4000 > cpu/config=2,period=300000/: sample_period=300000 > > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/evsel.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index f664a22b5fea..04fddddc6b6f 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -2158,8 +2158,13 @@ int perf_evsel__fprintf(struct perf_evsel *evsel, > printed += perf_event_attr__fprintf(fp, &evsel->attr, > __print_attr__fprintf, &first); > } else if (details->freq) { > - printed += comma_fprintf(fp, &first, " sample_freq=%" PRIu64, > - (u64)evsel->attr.sample_freq); > + const char *term = "sample_freq"; > + > + if (!evsel->attr.freq) > + term = "sample_period"; > + > + printed += comma_fprintf(fp, &first, " %s=%" PRIu64, > + term, (u64)evsel->attr.sample_freq); > } > out: > fputc('\n', fp); > -- > 2.5.0 >