From: David Miller <davem@davemloft.net>
To: jmaxwell37@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jmaxwell@redhat.com
Subject: Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()
Date: Mon, 10 Aug 2015 21:22:56 -0700 (PDT) [thread overview]
Message-ID: <20150810.212256.1658635789817625453.davem@davemloft.net> (raw)
In-Reply-To: <1439256746-7953-1-git-send-email-jmaxwell37@gmail.com>
From: Jon Maxwell <jmaxwell37@gmail.com>
Date: Tue, 11 Aug 2015 11:32:26 +1000
> We have seen a few crashes recently where a NIC is getting
> reset for some reason and then the driver or another module calls
> printk() which invokes netconsole. Netconsole then calls the
> adapter specific poll routine via netpoll which crashes because
> the adapter is resetting and its structures are being reinitialized.
This isn't a fix.
What if the carrier check passes, and then the chip reset starts on
another cpu? You'll have the same problem.
I'm not applying this, sorry.
next prev parent reply other threads:[~2015-08-11 4:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 1:32 Jon Maxwell
2015-08-11 4:22 ` David Miller [this message]
2015-08-11 5:53 ` Jonathan Maxwell
2015-08-11 17:25 ` David Miller
2015-08-12 3:06 ` Jonathan Maxwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810.212256.1658635789817625453.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmaxwell37@gmail.com \
--cc=jmaxwell@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®