From: David Miller <davem@davemloft.net>
To: robert.richter@caviumnetworks.com
Cc: ddaney@caviumnetworks.com, ddaney.cavm@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, tomasz.nowicki@linaro.org,
sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org,
linux-acpi@vger.kernel.org, mark.rutland@arm.com,
rafael@kernel.org, david.daney@cavium.com
Subject: Re: [PATCH v2 0/2] net: thunder: Add ACPI support.
Date: Tue, 11 Aug 2015 13:50:19 -0700 (PDT) [thread overview]
Message-ID: <20150811.135019.576312282566025940.davem@davemloft.net> (raw)
In-Reply-To: <20150811201237.GW4914@rric.localhost>
From: Robert Richter <robert.richter@caviumnetworks.com>
Date: Tue, 11 Aug 2015 22:12:37 +0200
> On 11.08.15 13:04:55, David Daney wrote:
>> >In the future it might be better structured to try and get the OF
>> >node, and if that fails then try and use the ACPI method to obtain
>> >these values.
>>
>> Our current approach, as you can see in the patch, is the opposite. If ACPI
>> is being used, prefer that over the OF device tree.
>>
>> You seem to be recommending precedence for OF. It should be consistent
>> across all drivers/sub-systems, so do you really think that OF before ACPI
>> is the way to go?
>
> If ACPI is enabled then no OF function may be called at all.
That makes no sense to me at all.
If ACPI is enabled, the OF routines should return no nodes etc.
next prev parent reply other threads:[~2015-08-11 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 0:58 David Daney
2015-08-11 0:58 ` [PATCH v2 1/2] net: thunder: Factor out DT specific code in BGX David Daney
2015-08-11 0:58 ` [PATCH v2 2/2] net, thunder, bgx: Add support to get MAC address from ACPI David Daney
2015-08-11 18:49 ` [PATCH v2 0/2] net: thunder: Add ACPI support David Miller
2015-08-11 20:04 ` David Daney
2015-08-11 20:12 ` Robert Richter
2015-08-11 20:50 ` David Miller [this message]
2015-08-11 20:49 ` David Miller
2015-08-12 15:23 ` Catalin Marinas
2015-08-12 15:36 ` David Daney
2015-08-13 8:34 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811.135019.576312282566025940.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=sgoutham@cavium.com \
--cc=tomasz.nowicki@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®