From: Darren Hart <dvhart@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: "Chen, Yu C" <yu.c.chen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"jslaby@suse.com" <jslaby@suse.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons
Date: Mon, 10 Aug 2015 19:56:51 -0700 [thread overview]
Message-ID: <20150811025651.GB3095@vmdeb7> (raw)
In-Reply-To: <1438887329.2679.64.camel@perches.com>
On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
> On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> > On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote:
> []
> > > Is it ok to keep these codes and add comments like:
>
> It's your code Yu, do whatever you think appropriate.
>
> > > /*
> > > * When a button(power button/volume button/home button) is
> > > * pressed down or released, different ACPI notification codes
> > > * will be generated. We can distinguish different event code
> > > * and value of buttons by these notification codes, then pass
> > > * (EV_KEY, event code(key_code), value(pressed)) to input layer.
> > > */
> >
> > The commentary is useful regardless. However, I suspect Joe was
> > referring to the approach pairing the PRESS and RELEASE cases?
> >
>
> True.
>
> btw Darren, your computer's email time setting seems off.
Nothing gets past kernel devs! Corporate firewall broke ntp for Linux VM from
where I sent this, didn't notice until too late.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-11 2:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:16 Chen Yu
2015-08-06 5:30 ` Joe Perches
2015-08-06 11:20 ` Chen, Yu C
2015-08-05 23:47 ` Darren Hart
2015-08-06 18:55 ` Joe Perches
2015-08-11 2:56 ` Darren Hart [this message]
2015-08-07 7:49 ` Chen, Yu C
2015-08-06 14:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811025651.GB3095@vmdeb7 \
--to=dvhart@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mika.westerberg@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®