From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature
Date: Tue, 11 Aug 2015 13:15:07 +0200 [thread overview]
Message-ID: <20150811111507.GN16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1439290813-6683-4-git-send-email-srikar@linux.vnet.ibm.com>
On Tue, Aug 11, 2015 at 04:30:13PM +0530, Srikar Dronamraju wrote:
> Variable sched_numa_balancing is available for both CONFIG_SCHED_DEBUG
> and !CONFIG_SCHED_DEBUG. All code paths now check for
> sched_numa_balancing. Hence remove sched_feat(NUMA).
>
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/sched/core.c | 6 ------
> kernel/sched/features.h | 16 ----------------
> 2 files changed, 22 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7cbdf44..d02570b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2063,12 +2063,6 @@ __read_mostly bool sched_numa_balancing;
> void set_numabalancing_state(bool enabled)
> {
> sched_numa_balancing = enabled;
> -#ifdef CONFIG_SCHED_DEBUG
> - if (enabled)
> - sched_feat_set("NUMA");
> - else
> - sched_feat_set("NO_NUMA");
> -#endif /* CONFIG_SCHED_DEBUG */
> }
Could you at least replace sched_numa_balancing with a static_key
thingy?
next prev parent reply other threads:[~2015-08-11 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 11:00 [PATCH v2 0/3] Disable sched_numa_balancing on uma systems Srikar Dronamraju
2015-08-11 11:00 ` [PATCH v2 1/3] sched/numa: Rename numabalancing_enabled to sched_numa_balancing Srikar Dronamraju
2015-09-13 11:01 ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2015-08-11 11:00 ` [PATCH v2 2/3] sched/numa: Disable sched_numa_balancing on uma systems Srikar Dronamraju
2015-09-13 11:02 ` [tip:sched/core] sched/numa: Disable sched_numa_balancing on UMA systems tip-bot for Srikar Dronamraju
2015-08-11 11:00 ` [PATCH v2 3/3] sched/numa: Remove NUMA sched feature Srikar Dronamraju
2015-08-11 11:15 ` Peter Zijlstra [this message]
2015-09-13 11:02 ` [tip:sched/core] sched/numa: Remove the NUMA sched_feature tip-bot for Srikar Dronamraju
2015-08-11 16:24 ` [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Srikar Dronamraju
2015-09-06 4:01 ` Wanpeng Li
2015-09-07 4:10 ` Srikar Dronamraju
2015-09-07 5:21 ` Wanpeng Li
2015-09-13 11:03 ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2015-09-02 9:33 ` [PATCH v2 0/3] Disable sched_numa_balancing on uma systems Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811111507.GN16853@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome