From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934351AbbHKMvd (ORCPT ); Tue, 11 Aug 2015 08:51:33 -0400 Received: from verein.lst.de ([213.95.11.211]:40068 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934106AbbHKMvc (ORCPT ); Tue, 11 Aug 2015 08:51:32 -0400 Date: Tue, 11 Aug 2015 14:51:30 +0200 From: Christoph Hellwig To: Dan Williams Cc: linux-kernel@vger.kernel.org, ross.zwisler@linux.intel.com, mcgrof@suse.com, hch@lst.de, linux-nvdimm@ml01.01.org Subject: Re: [PATCH v4 06/10] libnvdimm, pmem: push call to ioremap_cache out of line Message-ID: <20150811125130.GB3402@lst.de> References: <20150811033345.4987.17983.stgit@otcpl-bsw-rvp-2.jf.intel.com> <20150811033823.4987.83902.stgit@otcpl-bsw-rvp-2.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150811033823.4987.83902.stgit@otcpl-bsw-rvp-2.jf.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 11:38:23PM -0400, Dan Williams wrote: > In preparation for deprecating ioremap_cache() push its usage into arch > code where it deleted in a later globabl conversion of ioremap_cache() > to arch_memremap(). I don't really see the point of this patch. Two patches later we'll get rid arch_memremap_pmem anyway. I'd rather fold this and the next two patches into a single one, and keep the new arch_memremap_pmem_flags as a inline in io.h.