From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933619AbbHKXEH (ORCPT ); Tue, 11 Aug 2015 19:04:07 -0400 Received: from smtp.outflux.net ([198.145.64.163]:38754 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932932AbbHKXEE (ORCPT ); Tue, 11 Aug 2015 19:04:04 -0400 Date: Tue, 11 Aug 2015 16:04:01 -0700 From: Kees Cook To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: [PATCH] fs-create-and-use-seq_show_option-for-escaping-fix2 Message-ID: <20150811230401.GA9072@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The buildbots noticed seq_show_option should be using const parameters. Signed-off-by: Kees Cook --- include/linux/seq_file.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h index ff4c631348dd..d4c7271382cb 100644 --- a/include/linux/seq_file.h +++ b/include/linux/seq_file.h @@ -155,7 +155,8 @@ static inline struct user_namespace *seq_user_ns(struct seq_file *seq) * @name: the mount option name * @value: the mount option name's value, can be NULL */ -static inline void seq_show_option(struct seq_file *m, char *name, char *value) +static inline void seq_show_option(struct seq_file *m, const char *name, + const char *value) { seq_putc(m, ','); seq_escape(m, name, ",= \t\n\\"); -- 1.9.1 -- Kees Cook Chrome OS Security