From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Mirko Lindner <mlindner@marvell.com>,
"ryan.harkin@linaro.org" <ryan.harkin@linaro.org>,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad
Date: Wed, 12 Aug 2015 17:00:37 +0100 [thread overview]
Message-ID: <20150812160037.GX20890@e106497-lin.cambridge.arm.com> (raw)
In-Reply-To: <20150812082823.4d62ee26@urahara>
On Wed, Aug 12, 2015 at 04:28:23PM +0100, Stephen Hemminger wrote:
> On Wed, 12 Aug 2015 10:30:05 +0100
> Liviu Dudau <Liviu.Dudau@arm.com> wrote:
>
> > On Tue, Aug 11, 2015 at 06:01:32PM +0100, Stephen Hemminger wrote:
> > > On Tue, 11 Aug 2015 15:35:56 +0100
> > > Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> > >
> > > > On some embedded systems the EEPROM does not contain a valid MAC address.
> > > > In that case it is better to fallback to a generated mac address and
> > > > let init scripts fix the value later.
> > > >
> > > > Reported-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > [Changed handcoded setup to use eth_hw_addr_random() instead]
> > > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > > > ---
> > > > I have tested this on my Juno platform and I can successfully do an nfsroot boot.
> > > >
> > > > Best regards,
> > > > Liviu
> > > >
> > > > drivers/net/ethernet/marvell/sky2.c | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> > > > index d9f4498..c309879 100644
> > > > --- a/drivers/net/ethernet/marvell/sky2.c
> > > > +++ b/drivers/net/ethernet/marvell/sky2.c
> > > > @@ -4819,6 +4819,13 @@ static struct net_device *sky2_init_netdev(struct sky2_hw *hw, unsigned port,
> > > > memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8,
> > > > ETH_ALEN);
> > > >
> > > > + /* if the address is invalid, use a random value */
> > > > + if (!is_valid_ether_addr(dev->dev_addr)) {
> > > > + netdev_warn(dev,
> > > > + "Invalid MAC address, defaulting to random\n");
> > > > + eth_hw_addr_random(dev);
> > > > + }
> > > > +
> > > > return dev;
> > > > }
> > > >
> > >
> > > This is not enough, you need to program the hardware with the new random MAC
> > > address. The easiest way is calling sky2_set_mac_address, but you need to convert
> > > the address from array back to sockaddr.
> > >
> >
> > OK, I am a bit confused as to why sky2_set_mac_address is needed here, as this was not
> > required by the existing function. Given that in my tests I get a random MAC address
> > assigned every time to the device and I can see the same MAC address with ifconfig, how
> > can I test the effect of sky2_set_mac_address if I add it?
>
> The network device address is stored in two places. One is in the
> kernel (dev->dev_addr) and is used by networking stack.
> The other is the hardware (actually two places) and is used filtering received packets
> in the PHY and for sending hardware generated pause frames.
>
> When a random address is generated, you need to tell the hardware
> to use that address as well. I suspect your hardware maybe limited in functionality
> and not do the normal filtering.
>
I understand now, thanks for explaining it. I admit my tests were very limited and I did not
try to capture any packets using the interface. I thought the DHCP discovery requires the
MAC address to be correct in the hardware to work, but it might be that the kernel's DHCP
client is more thorough than userspace.
I will add the setting of the MAC address in v3.
Best regards,
Liviu
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2015-08-12 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:50 [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-05 16:40 ` Stephen Hemminger
2015-08-05 17:16 ` Liviu Dudau
2015-08-05 20:33 ` Francois Romieu
2015-08-05 23:16 ` Stephen Hemminger
2015-08-06 0:33 ` Florian Fainelli
2015-08-11 14:35 ` [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau
2015-08-11 17:01 ` Stephen Hemminger
2015-08-12 9:30 ` Liviu Dudau
2015-08-12 15:28 ` Stephen Hemminger
2015-08-12 16:00 ` Liviu Dudau [this message]
2015-08-11 18:56 ` Sergei Shtylyov
2015-08-12 9:15 ` Liviu Dudau
[not found] ` <CAD0U-h+Lbz+bygVCaF1Ji0VPLfh9sn504rCeGigXLER+H=KnZg@mail.gmail.com>
2015-08-05 17:18 ` [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-06 0:32 ` David Miller
2015-08-06 10:31 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812160037.GX20890@e106497-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=ryan.harkin@linaro.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®