From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbbHMHOz (ORCPT ); Thu, 13 Aug 2015 03:14:55 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:33951 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbbHMHOy (ORCPT ); Thu, 13 Aug 2015 03:14:54 -0400 Date: Thu, 13 Aug 2015 09:14:50 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Chanwoo Choi Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, rogerq@ti.com Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Message-ID: <20150813071450.GX9999@pengutronix.de> References: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote: > Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > changes the prototype of devm_gpiod_get_optional() API which should include > the falgs mandatory. I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to pass the flags argument." After all it is possible (and recommended) already now to use it. Your wording sounds as if b17d1bf16cc7 changed the API in an incompatible way. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |