From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbbHMIks (ORCPT ); Thu, 13 Aug 2015 04:40:48 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:38908 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbbHMIkp (ORCPT ); Thu, 13 Aug 2015 04:40:45 -0400 Date: Thu, 13 Aug 2015 10:40:42 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Chanwoo Choi Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, rogerq@ti.com Subject: Re: [PATCH v2] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Message-ID: <20150813084042.GC9999@pengutronix.de> References: <1439453825-5780-1-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1439453825-5780-1-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2015 at 05:17:05PM +0900, Chanwoo Choi wrote: > "With commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") s/"// > it becomes necessary to pass the flags argument. And this patch add the gpio s/add/adds/ > header file to fix the build break when use random configuration file. s/break/breakage/; s/use/build testing with/; s/file/files/ (That's at least what my German mind tells ...) > Reported-by: Stephen Rothwell > Signed-off-by: Chanwoo Choi > --- > drivers/extcon/extcon-palmas.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index 662e91778cb0..93c30a885740 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > > #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ > @@ -208,7 +209,8 @@ static int palmas_usb_probe(struct platform_device *pdev) > palmas_usb->wakeup = pdata->wakeup; > } > > - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id"); > + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", > + GPIOD_IN); This isn't aligned with the opening parenthesis in the line above. But IIRC this isn't a hard requirement, so *shrug*. Acked-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |