From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbbHMUnJ (ORCPT ); Thu, 13 Aug 2015 16:43:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53869 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbbHMUnI (ORCPT ); Thu, 13 Aug 2015 16:43:08 -0400 Date: Thu, 13 Aug 2015 13:43:06 -0700 From: Andrew Morton To: Simon Horman Cc: Minfei Huang , vgoyal@redhat.com, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-Id: <20150813134306.70faabec1634fa3cd777a212@linux-foundation.org> In-Reply-To: <20150813005525.GB7852@verge.net.au> References: <1438058802-6462-1-git-send-email-mnfhuang@gmail.com> <20150813005525.GB7852@verge.net.au> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Aug 2015 09:55:25 +0900 Simon Horman wrote: > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > we can simplify the code logic to do the image->control_page assignment > > directly in the loop, and remove the unnecessary conditional judgement. > > > > Signed-off-by: Minfei Huang > > Acked-by: Dave Young > > Acked-by: Vivek Goyal > > Andrew, could you consider picking this up. > It seems to have been sufficiently reviewed, acked, etc... I grabbed this one of July 28. http://ozlabs.org/~akpm/mmotm/broken-out/kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch