From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754056AbbHNIQZ (ORCPT ); Fri, 14 Aug 2015 04:16:25 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35311 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbbHNIQV (ORCPT ); Fri, 14 Aug 2015 04:16:21 -0400 Date: Fri, 14 Aug 2015 10:16:17 +0200 From: Andrey Shvetsov To: Tomas Melin Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/most: fix return value for DIM_GetChannelState Message-ID: <20150814081617.GA4158@arch.fritz.box> References: <1439129321-27130-1-git-send-email-tomas.melin@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439129321-27130-1-git-send-email-tomas.melin@iki.fi> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote: > Return NULL instead of 0 for invalid input. > > Signed-off-by: Tomas Melin Signed-off-by: Andrey Shvetsov > --- > drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c > index 01b7489..a54cf2c 100644 > --- a/drivers/staging/most/hdm-dim2/dim2_hal.c > +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c > @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch, > struct dim_ch_state_t *state_ptr) > { > if (!ch || !state_ptr) > - return 0; > + return NULL; > > state_ptr->ready = ch->state.level < 2; > state_ptr->done_buffers = ch->done_sw_buffers_number; > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel