From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122AbbHOCLe (ORCPT ); Fri, 14 Aug 2015 22:11:34 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44172 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753295AbbHOCLb (ORCPT ); Fri, 14 Aug 2015 22:11:31 -0400 Date: Fri, 14 Aug 2015 17:25:06 +0100 From: Mark Brown To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, sboyd@codeaurora.org, nm@ti.com, Liam Girdwood , "open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" Message-ID: <20150814162506.GV10748@sirena.org.uk> References: <28971ff9b110d18970fcc6291531f617cda18230.1439553400.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w5nY8nmEklXMR7Cj" Content-Disposition: inline In-Reply-To: <28971ff9b110d18970fcc6291531f617cda18230.1439553400.git.viresh.kumar@linaro.org> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 70.98.210.100 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --w5nY8nmEklXMR7Cj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 14, 2015 at 05:30:55PM +0530, Viresh Kumar wrote: > The OPP (Operating performance points) v2 bindings allows regulator > voltage to be supplied as a triplet of voltages. Looking at this I really don't understand why you tried to get me to review this via an IRC pastebin instead of following the normal patch submission process. Please don't do that, it's not at all helpful. IRC can be useful for interactive discussions or things that are really urgent, not for normal upstream code review. > +static inline int regulator_set_voltage_triplet(struct regulator *regula= tor, > + int target_uV, int min_uV, > + int max_uV) This seems awkward, these things are normally written as min <=3D target <=3D max but this is target, min, max. > static inline int regulator_set_voltage_tol(struct regulator *regulator, > int new_uV, int tol_uV) > { > --=20 > 2.4.0 You've not added a stub for the new function. --w5nY8nmEklXMR7Cj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVzhZhAAoJECTWi3JdVIfQJHcH/21egPJOqJN09FMawBwHgTZe aBxU2wsNPiYPrzG4zauquMKnqk9UCEAHTHErsLbmowFipdCmjAil7apuuQ4viqr4 +86dl+1lbzWUeWx1OuJMo3sJixX7CKMDrAnMox6zTJB2idDhjjB1AUBMsA0Njr74 viC8G3u/azySjIgsLa6htzVlI8RSySUnRXBoOSBYSoSAaksWnitRkTepSx7eTqtO KbNRFTmqcEu7H9+20DUCQZVuwKEdq3kewpKyhiuLaLBbAUs2AxC0osSNy2FGDUkO jWqdl9QuX699nP4ZgeXceSk7k+q2YhyJ1f+bAb55VJ1nUuSQ9HjAWfE6jpM7wyI= =kj+J -----END PGP SIGNATURE----- --w5nY8nmEklXMR7Cj--