From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbbHNTFm (ORCPT ); Fri, 14 Aug 2015 15:05:42 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:40835 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbbHNTFl (ORCPT ); Fri, 14 Aug 2015 15:05:41 -0400 Date: Fri, 14 Aug 2015 21:05:35 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org, Timo Kokkonen , linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH v2 4/8] watchdog: Make set_timeout function optional Message-ID: <20150814190535.GV9999@pengutronix.de> References: <1439010167-13818-1-git-send-email-linux@roeck-us.net> <1439010167-13818-5-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1439010167-13818-5-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guenter, On Fri, Aug 07, 2015 at 10:02:43PM -0700, Guenter Roeck wrote: > For some watchdogs, the hardware timeout is fixed, and the > watchdog driver depends on the watchdog core to handle the > actual timeout. In this situation, the watchdog driver might > only set the 'timeout' variable but do nothing else. > This can as well be handled by the infrastructure, so make > the set_timeout callback optional. If WDIOF_SETTIMEOUT is > configured but the .set_timeout callback is not available, > update the timeout variable in the infrastructure code. > > Signed-off-by: Guenter Roeck Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |