From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754372AbbHOUXl (ORCPT <rfc822;w@1wt.eu>);
	Sat, 15 Aug 2015 16:23:41 -0400
Received: from sauhun.de ([89.238.76.85]:48182 "EHLO pokefinder.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754045AbbHOUXj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 15 Aug 2015 16:23:39 -0400
Date: Sat, 15 Aug 2015 22:23:05 +0200
From: Wolfram Sang <wsa@the-dreams.de>
To: York Sun <yorksun@freescale.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Peter Korsgaard <peter.korsgaard@barco.com>
Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg
Message-ID: <20150815202302.GB3463@katana>
References: <1434475692-4611-1-git-send-email-yorksun@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434475692-4611-1-git-send-email-yorksun@freescale.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 16, 2015 at 10:28:12AM -0700, York Sun wrote:
> Based on i2c-mux-gpio driver, similarly the register based mux
> switch from one bus to another by setting a single register.
> The register can be on PCIe bus, local bus, or any memory-mapped
> address.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> CC: Wolfram Sang <wsa@the-dreams.de>
> CC: Peter Korsgaard <peter.korsgaard@barco.com>

Mostly good.

> +static int i2c_mux_reg_probe(struct platform_device *pdev)
> +{
> +	struct regmux *mux;
> +	struct i2c_adapter *parent;
> +	struct resource *res;
> +	int (*deselect)(struct i2c_adapter *, void *, u32);
> +	unsigned int initial_state, class;

gcc says:

drivers/i2c/muxes/i2c-mux-reg.c:182:15: warning: variable 'initial_state' set but not used [-Wunused-but-set-variable]

It seens you prepared for setting the initial state but don't do the
actual set?

> +static struct platform_driver i2c_mux_reg_driver = {
> +	.probe	= i2c_mux_reg_probe,
> +	.remove	= i2c_mux_reg_remove,
> +	.driver	= {
> +		.owner	= THIS_MODULE,

coccicheck says:

drivers/i2c/muxes/i2c-mux-reg.c:288:3-8: No need to set .owner here. The core will do it.

> +		.name	= "i2c-mux-reg",
> +	},
> +};

Thanks,

   Wolfram