From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbbHRF0Z (ORCPT ); Tue, 18 Aug 2015 01:26:25 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbbHRF0X (ORCPT ); Tue, 18 Aug 2015 01:26:23 -0400 Date: Mon, 17 Aug 2015 22:26:20 -0700 (PDT) Message-Id: <20150817.222620.475853456939322841.davem@davemloft.net> To: noamc@ezchip.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, talz@ezchip.com Subject: Re: [v1 0/6] *** nps_enet fixups *** From: David Miller In-Reply-To: References: <1439791119-26892-1-git-send-email-noamc@ezchip.com> <20150817.103607.1737876155019074073.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Aug 2015 22:26:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Noam Camus Date: Tue, 18 Aug 2015 05:04:20 +0000 > I followed "Hardware Architecture" section from: > http://www.linuxfoundation.org/collaborate/workgroups/networking/napi > and came up with "reduce processing latency" idea. That document has lots of incorrect advice, that's for sure. For one thing, it also says to count TX work against the budget, you absolutely should not do this. TX work is "free" compared to RX work (which is several orders of magnitude more expensive) and therefore should not count against the NAPI budget value.