From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbbHRGlG (ORCPT ); Tue, 18 Aug 2015 02:41:06 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:51136 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbbHRGlE convert rfc822-to-8bit (ORCPT ); Tue, 18 Aug 2015 02:41:04 -0400 Date: Tue, 18 Aug 2015 14:40:53 +0800 From: Huang Shijie To: Han Xu Cc: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, fabio.estevam@freescale.com, hofrat@osadl.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, vinod.koul@intel.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org Subject: Re: [PATCH v2 3/6] mtd: nand: gpmi: may use minimum required ecc for 744 oobsize NAND Message-ID: <20150818064053.GA10641@free64-pc.asiapac.arm.com> References: <1439868289-24843-1-git-send-email-b45815@freescale.com> MIME-Version: 1.0 In-Reply-To: <1439868289-24843-1-git-send-email-b45815@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-OriginalArrivalTime: 18 Aug 2015 06:40:59.0096 (UTC) FILETIME=[D7A8F580:01D0D980] X-MC-Unique: e2pUWqxVT12N3Bvs-xlA2g-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2015 at 10:24:49PM -0500, Han Xu wrote: > By default NAND driver will choose the highest ecc strength that oob > could contain, in this case, for some 8K+744 NAND flash, the ecc > strength will be up to 52bit, which beyonds the i.MX6QDL BCH capability > (40bit). > > This patch allows the NAND driver try to use minimum required ecc > strength if it failed to use the highest ecc, even without explicitly > claiming "fsl,use-minimum-ecc" in dts. > > Signed-off-by: Han Xu > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index dfd0ba1..01d24dd 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -136,7 +136,7 @@ static inline bool gpmi_check_ecc(struct gpmi_nand_data *this) > * > * We may have available oob space in this case. > */ > -static bool set_geometry_by_ecc_info(struct gpmi_nand_data *this) > +static int set_geometry_by_ecc_info(struct gpmi_nand_data *this) > { > struct bch_geometry *geo = &this->bch_geometry; > struct mtd_info *mtd = &this->mtd; > @@ -145,7 +145,7 @@ static bool set_geometry_by_ecc_info(struct gpmi_nand_data *this) > unsigned int block_mark_bit_offset; > > if (!(chip->ecc_strength_ds > 0 && chip->ecc_step_ds > 0)) > - return false; > + return -EINVAL; > > switch (chip->ecc_step_ds) { > case SZ_512: > @@ -158,19 +158,19 @@ static bool set_geometry_by_ecc_info(struct gpmi_nand_data *this) > dev_err(this->dev, > "unsupported nand chip. ecc bits : %d, ecc size : %d\n", > chip->ecc_strength_ds, chip->ecc_step_ds); > - return false; > + return -EINVAL; > } > geo->ecc_chunk_size = chip->ecc_step_ds; > geo->ecc_strength = round_up(chip->ecc_strength_ds, 2); > if (!gpmi_check_ecc(this)) > - return false; > + return -EINVAL; > > /* Keep the C >= O */ > if (geo->ecc_chunk_size < mtd->oobsize) { > dev_err(this->dev, > "unsupported nand chip. ecc size: %d, oob size : %d\n", > chip->ecc_step_ds, mtd->oobsize); > - return false; > + return -EINVAL; > } > > /* The default value, see comment in the legacy_set_geometry(). */ > @@ -242,7 +242,7 @@ static bool set_geometry_by_ecc_info(struct gpmi_nand_data *this) > + ALIGN(geo->ecc_chunk_count, 4); > > if (!this->swap_block_mark) > - return true; > + return 0; > > /* For bit swap. */ > block_mark_bit_offset = mtd->writesize * 8 - > @@ -251,7 +251,7 @@ static bool set_geometry_by_ecc_info(struct gpmi_nand_data *this) > > geo->block_mark_byte_offset = block_mark_bit_offset / 8; > geo->block_mark_bit_offset = block_mark_bit_offset % 8; > - return true; > + return 0; > } > > static int legacy_set_geometry(struct gpmi_nand_data *this) > @@ -366,10 +366,12 @@ static int legacy_set_geometry(struct gpmi_nand_data *this) > > int common_nfc_set_geometry(struct gpmi_nand_data *this) > { > - if (of_property_read_bool(this->dev->of_node, "fsl,use-minimum-ecc") > - && set_geometry_by_ecc_info(this)) > - return 0; > - return legacy_set_geometry(this); > + Please remove the empty line. > + if ((of_property_read_bool(this->dev->of_node, "fsl,use-minimum-ecc")) > + || legacy_set_geometry(this)) If the legacy_set_geometry() fails, it will print out an error message. could you please also change the error log? thanks Huang Shijie > + return set_geometry_by_ecc_info(this); > + > + return 0; > }