From: Mark Brown <broonie@kernel.org>
To: Peter Chen <peter.chen@freescale.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
balbi@ti.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
sojka@merica.cz, stern@rowland.harvard.edu,
r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com,
linux-usb@vger.kernel.org,
device-mainlining@lists.linuxfoundation.org, sre@kernel.org,
dbaryshkov@gmail.com, dwmw2@infradead.org, sameo@linux.intel.com,
lee.jones@linaro.org, patches@opensource.wolfsonmicro.com,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management
Date: Tue, 18 Aug 2015 09:12:00 -0700 [thread overview]
Message-ID: <20150818161200.GK10748@sirena.org.uk> (raw)
In-Reply-To: <20150818052011.GF1864@shlinux2>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Tue, Aug 18, 2015 at 01:20:12PM +0800, Peter Chen wrote:
> ok, I just had suspected below function's correctness, after looking
> it again, it always set 1800 as charging limit, does it be expected?
> + /* Find the highest supported limit */
> + best = 0;
> + for (i = 0; i < ARRAY_SIZE(wm831x_usb_limits); i++) {
> + if (limit < wm831x_usb_limits[i] &&
The above check is intended to ensure that we don't go over the limit
that was passed in in the callback. The goal is to select the highest
option that is less than the limit passed in.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-18 16:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 9:47 [PATCH v2 0/3] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2015-08-14 8:55 ` Li Jun
2015-08-14 11:04 ` Baolin Wang
2015-08-17 1:15 ` Li Jun
2015-08-17 6:02 ` Baolin Wang
2015-08-17 8:20 ` Li Jun
2015-08-17 11:51 ` Baolin Wang
2015-08-14 9:47 ` [PATCH v2 1/3] gadget: Support for the usb charger framework Baolin Wang
2015-08-17 0:40 ` Peter Chen
2015-08-17 2:08 ` Baolin Wang
2015-08-14 9:47 ` [PATCH v2 2/3] gadget: Introduce " Baolin Wang
2015-08-14 15:27 ` Greg KH
2015-08-17 3:03 ` Baolin Wang
2015-08-17 15:25 ` [Device-mainlining] " Tim Bird
2015-08-18 1:43 ` Baolin Wang
2015-10-08 15:50 ` Pavel Machek
2015-10-08 16:23 ` Greg KH
2015-10-08 17:04 ` Pavel Machek
2015-10-08 17:16 ` Greg KH
2015-08-17 17:24 ` Mark Brown
2015-08-18 1:44 ` Baolin Wang
2015-08-14 9:47 ` [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management Baolin Wang
2015-08-14 10:42 ` Lee Jones
2015-08-17 1:07 ` Peter Chen
2015-08-17 17:26 ` Mark Brown
2015-08-17 23:58 ` Felipe Balbi
2015-08-18 5:04 ` Mark Brown
2015-08-18 14:07 ` Felipe Balbi
2015-08-18 5:20 ` Peter Chen
2015-08-18 16:12 ` Mark Brown [this message]
2015-08-19 0:02 ` Peter Chen
2015-08-19 16:36 ` Mark Brown
2015-08-20 9:02 ` David Laight
2015-08-21 2:28 ` Baolin Wang
2017-07-03 6:07 [PATCH v2 0/3] Introduce USB charger support in USB phy Baolin Wang
2017-07-03 6:07 ` [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management Baolin Wang
2017-07-03 8:53 ` Charles Keepax
2017-07-04 7:27 ` Baolin Wang
2017-07-03 15:50 ` Sebastian Reichel
2017-07-04 7:20 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818161200.GK10748@sirena.org.uk \
--to=broonie@kernel.org \
--cc=balbi@ti.com \
--cc=baolin.wang@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=device-mainlining@lists.linuxfoundation.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.chen@freescale.com \
--cc=r.baldyga@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sojka@merica.cz \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®