From: Byungchul Park <byungchul.park@lge.com>
To: mingo@kernel.org, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, yuyang.du@intel.com
Subject: Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it
Date: Wed, 19 Aug 2015 15:59:42 +0900 [thread overview]
Message-ID: <20150819065942.GD24261@byungchulpark-X58A-UD3R> (raw)
In-Reply-To: <1439966836-11266-1-git-send-email-byungchul.park@lge.com>
On Wed, Aug 19, 2015 at 03:47:11PM +0900, byungchul.park@lge.com wrote:
> From: Byungchul Park <byungchul.park@lge.com>
>
> hello,
>
> there are 3 problems when att(det)aching a se to(from) its cfs_rq.
>
> problem 1. se's average load is not accounted with new cfs_rq in queued case,
> when a task changes its cgroup.
>
> problem 2. cfs_rq->avg.load_avg becomes larger and larger whenever changing
> cgroup to another. we have to sync se's average load with prev cfs_rq.
>
> problem 3. current code does not sync it with its cfs_rq when switching
> sched class to fair class. if we can always assume that a se has been
> detached from fair class for a long time enough for its average load to
> become useless, at the time attaching it to its fair class cfs_rq, then
> current code is acceptable. but the assumption is not always true.
>
> patch 1/5, does code refactoring for further patches.
> patch 2/5, solves the problem 1.
> patch 3/5, solves the problem 2.
> patch 4/5, solves the problem 3.
> patch 5/5, does code refactoring for better readability.
>
> change from v2 to v1 (logic is not changed at all)
change from v2 to v3 (logic is not changed at all)
i am sorry for typo.
> * fix up my poor english in commit message and comment
> * break down big patches into more patches for being reviewed easily
> * supplement cover letter messages
>
> change from v1 to v2
> * introduce two functions for adjusting vruntime and load when attaching
> and detaching.
> * call the introduced functions instead of switched_from(to)_fair() directly
> in task_move_group_fair().
> * add decaying logic for a se which has detached from a cfs_rq.
>
> thanks,
> byungchul
>
> Byungchul Park (5):
> sched: add two functions adjusting cfs_rq's load when att(det)aching
> a se
> sched: make task_move_group_fair adjust cfs_rq's load in case of
> queued
> sched: sync a se with prev cfs_rq when changing cgroup
> sched: sync a se with its cfs_rq when switching sched class to fair
> class
> sched: add two functions for att(det)aching a task to(from) a cfs_rq
>
> kernel/sched/fair.c | 209 +++++++++++++++++++++++++++------------------------
> 1 file changed, 110 insertions(+), 99 deletions(-)
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-08-19 7:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 6:47 byungchul.park
2015-08-19 6:47 ` [PATCH v3 1/5] sched: add two functions adjusting cfs_rq's load when att(det)aching a se byungchul.park
2015-08-19 6:47 ` [PATCH v3 2/5] sched: make task_move_group_fair adjust cfs_rq's load in case of queued byungchul.park
2015-08-19 6:47 ` [PATCH v3 3/5] sched: sync a se with prev cfs_rq when changing cgroup byungchul.park
2015-08-19 6:47 ` [PATCH v3 4/5] sched: sync a se with its cfs_rq when switching sched class to fair class byungchul.park
2015-08-19 17:12 ` Peter Zijlstra
2015-08-19 20:11 ` Yuyang Du
2015-08-20 6:12 ` Byungchul Park
2015-08-20 21:13 ` Peter Zijlstra
2015-08-20 23:56 ` Byungchul Park
2015-08-20 5:23 ` Byungchul Park
2015-08-19 6:47 ` [PATCH v3 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq byungchul.park
2015-08-19 6:59 ` Byungchul Park [this message]
2015-08-20 1:17 ` [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it Peter Zijlstra
2015-08-20 5:26 ` Byungchul Park
2015-08-20 8:38 ` Byungchul Park
2015-08-20 10:46 ` Byungchul Park
2015-08-20 21:11 ` Peter Zijlstra
2015-08-21 0:01 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819065942.GD24261@byungchulpark-X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®