From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbbHSMab (ORCPT ); Wed, 19 Aug 2015 08:30:31 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:35737 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871AbbHSMaa (ORCPT ); Wed, 19 Aug 2015 08:30:30 -0400 Date: Wed, 19 Aug 2015 18:00:12 +0530 From: Chandra Gorentla To: Greg KH Cc: rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, johnny.kim@atmel.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH] staging: wilc1000: Set all options in region debugfs file Message-ID: <20150819123012.GA20877@gcs-HP-Compaq-nx6320> References: <1439917337-18473-1-git-send-email-csgorentla@gmail.com> <20150819030100.GE4588@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150819030100.GE4588@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote: > On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: > > This patch allows setting all options in the module's debug region > > options file 'wilc_debug_region'. This functionality allows the user > > to enable logging from all regions (initialization, locks, firmware > > etc.) of the driver. Logging from the following regions is enabled > > during the driver initialization: > > > > INIT_DBG, GENERIC_DBG, CFG80211_DBG, FIRM_DBG and HOSTAPD_DBG > > > > Before this change, the numerical value set is equal first byte of > > input minus 0x30 (ASCII value of '0'). Because of this, after a write > > to this debugfs file, it is difficult to predict the regions on which > > logging is enabled. > > > > The DBG_REGION_ALL now includes 3 additional regions TCP_ENH, SPIN_DEBUG > > and FIRM_DBG. > > Why did you add these extra ones? I added them because there is code support them and to avoid a holes in the range of the options. > > All of this should eventually just be deleted, as network drivers need > to use the networking driver debug interfaces, not their own crazy ones. In that case, can I assume that we are not going forward with this change? > > thanks, > > greg k-h Thank you, chandra