mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>, Robert Richter <rric@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Jan Stancek <jstancek@redhat.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Sherry Hurwitz <sherry.hurwitz@amd.com>
Subject: Re: [BUG/RFC] perf test fails on AMD CPUs
Date: Wed, 19 Aug 2015 17:47:00 +0200	[thread overview]
Message-ID: <20150819154700.GA19622@nazgul.tnic> (raw)
In-Reply-To: <20150819085546.GA5883@krava.local>

On Wed, Aug 19, 2015 at 10:55:46AM +0200, Jiri Olsa wrote:
> this is the perf breakpoint address:
>   000000000045b260 <test_function>:
> 
> this is trace_printk output for NEW microcode 0x6000832:
> 
> DEBUG EX
>             perf-893   [003] d...  1358.053633: sync_regs: sync_regs eregs ffff88012ecc7f58, regs ffff8800c9f1bf58
>             perf-893   [003] d...  1358.053635: do_debug: do_debug-1 regs ffff8800c9f1bf58, eflags 217, rip 45b260
>             perf-893   [003] d.h.  1358.053641: do_debug: do_debug-2 eflags 10217, rip 45b260
>             perf-893   [003] d...  1358.053642: prepare_exit_to_usermode: prepare_exit_to_usermode1 regs ffff8800c9f1bf58, eflags 10217, rip 45b260
>             perf-893   [003] d...  1358.053643: prepare_exit_to_usermode: prepare_exit_to_usermode3 regs ffff8800c9f1bf58, eflags 10217, rip 45b260

Yikes!

Something cleared EFLAGS.RF here. And the same thing doesn't happen with
the older ucode version. Are you sure nothing happens in-between
prepare_exit_to_usermode() and smp_irq_work_interrupt()?

It looks like nothing does because the timestamps are really close.

> WORK_IRQ
>  --->       perf-893   [003] d...  1358.053645: smp_irq_work_interrupt: smp_irq_work_interrupt1 regs ffff8800c9f1bf58, eflags 217, rip 45b260
>             perf-893   [003] d.h.  1358.053650: perf_event_wakeup: irq_work SIGIO
>             perf-893   [003] d...  1358.053651: smp_irq_work_interrupt: smp_irq_work_interrupt2 regs ffff8800c9f1bf58, eflags 217, rip 45b260
> 
>             perf-893   [003] d...  1358.053652: prepare_exit_to_usermode: prepare_exit_to_usermode1 regs ffff8800c9f1bf58, eflags 217, rip 45b260
> 
> 
> this is trace_printk output for OLD microcode 0x6000822:
> 
> DEBUG EX
>             perf-898   [005] d...    87.098816: sync_regs: sync_regs eregs ffff88012ed47f58, regs ffff8800c9c8ff58
>             perf-898   [005] d...    87.098817: do_debug: do_debug-1 regs ffff8800c9c8ff58, eflags 217, rip 45b260
>             perf-898   [005] d.h.    87.098823: do_debug: do_debug-2 eflags 10217, rip 45b260
>             perf-898   [005] d...    87.098824: prepare_exit_to_usermode: prepare_exit_to_usermode1 regs ffff8800c9c8ff58, eflags 10217, rip 45b260
>             perf-898   [005] d...    87.098825: prepare_exit_to_usermode: prepare_exit_to_usermode3 regs ffff8800c9c8ff58, eflags 10217, rip 45b260
> 
> WORK_IRQ
>  --->       perf-898   [005] d...    87.098827: smp_irq_work_interrupt: smp_irq_work_interrupt1 regs ffff8800c9c8ff58, eflags 10217, rip 45b260
>             perf-898   [005] d.h.    87.098832: perf_event_wakeup: irq_work SIGIO
>             perf-898   [005] d...    87.098833: smp_irq_work_interrupt: smp_irq_work_interrupt2 regs ffff8800c9c8ff58, eflags 10217, rip 45b260
> 
>             perf-898   [005] d...    87.098833: prepare_exit_to_usermode: prepare_exit_to_usermode1 regs ffff8800c9c8ff58, eflags 10217, rip 45b260

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

  reply	other threads:[~2015-08-19 15:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-16 22:29 Jiri Olsa
2015-08-17  4:36 ` Borislav Petkov
2015-08-17  7:33   ` Jiri Olsa
2015-08-17 16:06   ` Andy Lutomirski
2015-08-18  8:52     ` Borislav Petkov
2015-08-18 10:10     ` Jiri Olsa
2015-08-19  3:55       ` Borislav Petkov
2015-08-19  8:55         ` Jiri Olsa
2015-08-19 15:47           ` Borislav Petkov [this message]
2015-08-19 15:58             ` Jiri Olsa
2015-08-19 16:12               ` Borislav Petkov
2015-08-21  7:45                 ` Jiri Olsa
2015-08-24 22:37       ` sherry hurwitz
2015-12-10 19:26         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150819154700.GA19622@nazgul.tnic \
    --to=bp@suse.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=rric@kernel.org \
    --cc=sherry.hurwitz@amd.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®