From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbHSQEk (ORCPT ); Wed, 19 Aug 2015 12:04:40 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:12770 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbbHSQEj (ORCPT ); Wed, 19 Aug 2015 12:04:39 -0400 Date: Wed, 19 Aug 2015 09:04:33 -0700 From: Bjorn Andersson To: Axel Lin CC: Mark Brown , Andy Gross , "Bird, Tim" , Liam Girdwood , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo Message-ID: <20150819160433.GW13472@usrtlx11787.corpusers.net> References: <1439954273.19082.2.camel@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1439954273.19082.2.camel@ingics.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote: > Just setting fixed_uV is not enough, the regulator core will also check > n_voltages setting. The fixed_uV only works when n_voltages is 1. > Thanks, I missed that. Reviewed-by: Bjorn Andersson > Signed-off-by: Axel Lin > --- > drivers/regulator/qcom_smd-regulator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c > index 9d093ae..9c6167d 100644 > --- a/drivers/regulator/qcom_smd-regulator.c > +++ b/drivers/regulator/qcom_smd-regulator.c > @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = { > > static const struct regulator_desc pm8941_lnldo = { > .fixed_uV = 1740000, > + .n_voltages = 1, > .ops = &rpm_smps_ldo_ops, > }; > > -- > 2.1.0 > > >