From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbbHTRz1 (ORCPT ); Thu, 20 Aug 2015 13:55:27 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53973 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbbHTRzZ (ORCPT ); Thu, 20 Aug 2015 13:55:25 -0400 Date: Thu, 20 Aug 2015 10:55:14 -0700 From: Mark Brown To: Vignesh R Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Message-ID: <20150820175514.GG12027@sirena.org.uk> References: <1440066659-5356-1-git-send-email-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bFsKbPszpzYNtEU6" Content-Disposition: inline In-Reply-To: <1440066659-5356-1-git-send-email-vigneshr@ti.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 69.84.245.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: ti-qspi: use 128 bit transfer mode for writing to flash X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bFsKbPszpzYNtEU6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 20, 2015 at 04:00:59PM +0530, Vignesh R wrote: > - writeb(*txbuf, qspi->base + QSPI_SPI_DATA_REG); > + if (count >= QSPI_WLEN_MAX_BYTES) { > + u32 *txp = (u32 *)txbuf; > + > + data = cpu_to_be32(*txp++); > + writel(data, qspi->base + > + QSPI_SPI_DATA_REG_3); > + data = cpu_to_be32(*txp++); > + writel(data, qspi->base + > + QSPI_SPI_DATA_REG_2); > + data = cpu_to_be32(*txp++); > + writel(data, qspi->base + > + QSPI_SPI_DATA_REG_1); > + data = cpu_to_be32(*txp++); > + writel(data, qspi->base + > + QSPI_SPI_DATA_REG); > + xfer_len = QSPI_WLEN_MAX_BYTES; > + cmd |= QSPI_WLEN(QSPI_WLEN_MAX_BITS); > + } else { > + writeb(*txbuf, qspi->base + QSPI_SPI_DATA_REG); > + cmd = qspi->cmd | QSPI_WR_SNGL; > + xfer_len = wlen; > + cmd |= QSPI_WLEN(wlen); > + } It's a bit sad that this isn't able to do a Duff's device type thing and only kicks in for the full 128 bit FIFO size, it looks like it could do any number of words. --bFsKbPszpzYNtEU6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV1hSCAAoJECTWi3JdVIfQRXYH/iI7LZuKRZcpcs1MGs/YjXEU 09E7wf8vNwRKaa+X3j2hTFiZi9deXyBeYzHYIrFpAbSyI33vZeF4P5IoEmRUMG6s zrVfh9KLl23Lrl5lCbx1ZeJ+0R9GrBQFPtR28U+bCjnvrexMD3oSKQ9u06Mmu3Hw YndZK2VK9j2wc4BiBJUYVOjbDSUY25CcaNIzrjpRcERuwHj+IYPe4fsSJL6jrQEW mwZ/XqpH4xDCr9BQ0SzSZ1YhLrNswXvvAy/fBQHUCqFmAE8B/mhic4Gs9UQ4sRQF V4rD4FgGuUC329w7tg4r4mvVtKN8I0e5+ZnAI8VpSK9K7dDBhTc3LQAUhCBW6iM= =o2kQ -----END PGP SIGNATURE----- --bFsKbPszpzYNtEU6--