From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbbHTS1f (ORCPT ); Thu, 20 Aug 2015 14:27:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54008 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbbHTS1e (ORCPT ); Thu, 20 Aug 2015 14:27:34 -0400 Date: Thu, 20 Aug 2015 11:27:25 -0700 From: Mark Brown To: Markus Pargmann Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Irina Tirdea , Stephen Boyd Message-ID: <20150820182725.GJ12027@sirena.org.uk> References: <1440061956-29064-1-git-send-email-mpa@pengutronix.de> <1440061956-29064-3-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iRjOs3ViPWHdlw/I" Content-Disposition: inline In-Reply-To: <1440061956-29064-3-git-send-email-mpa@pengutronix.de> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 69.84.245.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iRjOs3ViPWHdlw/I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 20, 2015 at 11:12:33AM +0200, Markus Pargmann wrote: > + } else if (map->use_single_rw) { > + /* > + * We need to handle bus writes separate to support val_bytes > + * that are not powers of 2. > + */ This comment is really hard to understand - the condition block we're in is nothing to do with the number of val_bytes and the comment is just making a statement, there's no why in there. --iRjOs3ViPWHdlw/I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV1hwJAAoJECTWi3JdVIfQ0C0H/i4KQFgYcafy/To4wrvXYqwl woGIaRXYPuw9rbEr+Z5/e5o1cugzjO+MBoNukjcWR6SvXvjA9PCyj/Qdjo2TwjBM Taf/b880l4lNnEPfJZvQ4O61B9O4mVE5nbWYnnA4KpNN/HE1myts1sKBwUyQDlYN Ow5BUxkyz7/9TQ/ZDWPPNIWOojxRi53VS0ECAaC7cXbN6020MBLu1iGe5ZpgRJOv 32m3yCU0xLlrf3o3nwPlbqAbTgGUPCNtO/lBKGjuQjwdVdmnGKw4GtGM1ivK2pw4 hHrOSCDhmYZe7x2o7gHPs9yLmf90X59h0Tfuhaynb0Sv/oR7o6s8wXXf5PPWick= =vQ8+ -----END PGP SIGNATURE----- --iRjOs3ViPWHdlw/I--