From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
Irina Tirdea <irina.tirdea@intel.com>
Subject: Re: [PATCH v2 4/5] regmap: regmap_raw_read return error on !bus->read
Date: Thu, 20 Aug 2015 11:30:03 -0700 [thread overview]
Message-ID: <20150820183003.GL12027@sirena.org.uk> (raw)
In-Reply-To: <1440061956-29064-5-git-send-email-mpa@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
On Thu, Aug 20, 2015 at 11:12:35AM +0200, Markus Pargmann wrote:
> Return -ENOTSUPP if map->bus->read is not implemented and we do not use
> the cache. This code path would directly use bus->read would run into an
> NULL pointer for the read function.
Please put fixes like this before coding style changes like patch 3.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-20 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 9:12 [PATCH v2 0/5] regmap: fixes Markus Pargmann
2015-08-20 9:12 ` [PATCH v2 1/5] regmap: Add missing comments about struct regmap_bus Markus Pargmann
2015-08-20 18:20 ` Mark Brown
2015-08-20 9:12 ` [PATCH v2 2/5] regmap: Fix regmap_bulk_write for bus writes Markus Pargmann
2015-08-20 18:27 ` Mark Brown
2015-08-20 9:12 ` [PATCH v2 3/5] regmap: Split use_single_rw internally into use_single_read/write Markus Pargmann
2015-08-20 18:28 ` Mark Brown
2015-08-20 9:12 ` [PATCH v2 4/5] regmap: regmap_raw_read return error on !bus->read Markus Pargmann
2015-08-20 18:30 ` Mark Brown [this message]
2015-08-20 9:12 ` [PATCH v2 5/5] regmap: No multi_write support if bus->write does not exist Markus Pargmann
2015-08-20 18:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820183003.GL12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=irina.tirdea@intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®