From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbbHTSp1 (ORCPT ); Thu, 20 Aug 2015 14:45:27 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54089 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbbHTSpZ (ORCPT ); Thu, 20 Aug 2015 14:45:25 -0400 Date: Thu, 20 Aug 2015 11:45:04 -0700 From: Mark Brown To: Michal Suchanek Cc: linux-sunxi@googlegroups.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20150820184504.GP12027@sirena.org.uk> References: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MWF3YmTHhoLNIVQC" Content-Disposition: inline In-Reply-To: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 69.84.245.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MWF3YmTHhoLNIVQC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. You should always be using the transfer speed that is defined per transfer, the core will ensure that this is always set. --MWF3YmTHhoLNIVQC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV1iAvAAoJECTWi3JdVIfQhFcH/jLdoyzn5IZMy9jbI5MnXjKf SE/RUeGiUazreW8Cg9dqsrp6VT9jEuVHyBjjhZnEeBOBbgmJjB3dzHWWvfueLb22 +cgo3CEWQ5WhaoX9fqAwzLTy9ZWyZmQzVeQ+YAPqkz+mItcIt9GrdUVVMu5aXwve Iz1cc180OgXg6977RSkCo/YBz5Yx8OpYQ0vdWUEaf/6hjvtePRBNaZYGFwuLD65+ zH1JLtwgU/IOpqP4VDOxdgWbbxrYNpr+lbbNrRhYBleZ+H9VMwMQt+y9Xjd3jK75 xz7yvZ9F7+OfFF0o0cRfaleAKZqyAFTLVArSpNskRl0bRbYiQy3DtQkVC3OqKuI= =nOG/ -----END PGP SIGNATURE----- --MWF3YmTHhoLNIVQC--