From: Mark Brown <broonie@kernel.org>
To: "Emilio López" <emilio@elopez.com.ar>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 4/9] spi: sun4i: add DMA support
Date: Thu, 20 Aug 2015 11:58:50 -0700 [thread overview]
Message-ID: <20150820185850.GQ12027@sirena.org.uk> (raw)
In-Reply-To: <ccf776869b0d7fe2c78bcc41d6cd1896bf732296.1440080122.git.hramrach@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Thu, Aug 20, 2015 at 02:19:46PM -0000, Emilio López wrote:
> - sun4i_spi_drain_fifo(sspi, SUN4I_FIFO_DEPTH);
> + if (sun4i_spi_can_dma(master, spi, tfr) && desc_rx) {
> + /* The receive transfer should be the last one to finish */
> + dma_wait_for_async_tx(desc_rx);
What if it's a transmit only transfer? We'll fall over to this...
> + } else {
> + sun4i_spi_drain_fifo(sspi, SUN4I_FIFO_DEPTH);
> + }
...which manually reads data from the FIFO which doesn't seem like what
we want, won't it conflict with the DMA?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-20 18:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1440080122.git.hramrach@gmail.com>
[not found] ` <a40fbf7ca8bd36f08f5e9d3fb6f6de2454066af7.1440080122.git.hramrach@gmail.com>
2015-08-20 14:45 ` [PATCH 2/9] spi: sun4i: fix FIFO limit Maxime Ripard
[not found] ` <a5a061d98b7ff851866cc668cd8bf8f6fc99d002.1440080122.git.hramrach@gmail.com>
2015-08-20 14:58 ` [PATCH 5/9] ARM: dts: sun7i: cubieboard2: Enable SPI0 Maxime Ripard
[not found] ` <90730047894f6ec84cd70062a27b7085c2016260.1440080122.git.hramrach@gmail.com>
2015-08-20 15:00 ` [PATCH 7/9] ARM: dts: sun5i: add SPI pins on A13 and A10s Maxime Ripard
[not found] ` <0e0b52774a48ddb71dc8095b66942451cd31ff7d.1440080122.git.hramrach@gmail.com>
2015-08-20 14:43 ` [PATCH 1/9] spi: sunxi: fix transfer timeout Maxime Ripard
2015-08-20 18:41 ` Mark Brown
2015-08-20 19:34 ` Maxime Ripard
2015-08-20 21:08 ` Mark Brown
2015-08-20 21:18 ` Maxime Ripard
2015-08-20 21:29 ` Mark Brown
[not found] ` <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com>
2015-08-20 14:48 ` [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Maxime Ripard
2015-08-20 19:45 ` Michal Suchanek
2015-08-20 21:23 ` Maxime Ripard
2015-08-20 18:45 ` Mark Brown
[not found] ` <ccf776869b0d7fe2c78bcc41d6cd1896bf732296.1440080122.git.hramrach@gmail.com>
2015-08-20 14:24 ` [linux-sunxi] [PATCH 4/9] spi: sun4i: add DMA support Michal Suchanek
2015-08-20 14:56 ` Maxime Ripard
2015-08-20 18:58 ` Mark Brown [this message]
2016-05-17 5:44 ` [linux-sunxi] " Michal Suchanek
2015-08-20 19:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820185850.GQ12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®