From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbbHTW7v (ORCPT ); Thu, 20 Aug 2015 18:59:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48848 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752083AbbHTW7u (ORCPT ); Thu, 20 Aug 2015 18:59:50 -0400 Date: Fri, 21 Aug 2015 00:59:47 +0200 From: Alexandre Belloni To: Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, cw00.choi@samsung.com, k.kozlowski@samsung.com Subject: Re: [PATCH v2] rtc: s3c: fix disabled clocks for alarm Message-ID: <20150820225947.GB3769@piout.net> References: <1439374906-27841-1-git-send-email-jy0922.shim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439374906-27841-1-git-send-email-jy0922.shim@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2015 at 19:21:46 +0900, Joonyoung Shim wrote : > The clock enable/disable codes for alarm have been removed from > commit 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock > control") and the clocks are disabled even if alarm is set, so alarm > interrupt can't happen. > > The s3c_rtc_setaie function can be called several times with 'enabled' > argument having same value, so it needs to check whether clocks are > enabled or not. > > Signed-off-by: Joonyoung Shim > Cc: # v4.1 > --- > This is v2 of prior patch "[PATCH 4/4] rtc: s3c: enable/disable clocks > for alarm". > > Changelog for v2: > - commit messages is modified by Krzysztof suggestion > - make to backportable patch > - add Cc-stable > > drivers/rtc/rtc-s3c.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > Applied, thanks. However, ... > @@ -39,6 +39,7 @@ struct s3c_rtc { > void __iomem *base; > struct clk *rtc_clk; > struct clk *rtc_src_clk; > + bool clk_disabled; > This is quite unusual and I would say the principle of least astonishment would require using clk_enabled and explicitly set it to true in the probe. I don't expect a lot of changes regarding the clocks in the probe so this is probably OK but doing so will require extra carefulness. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com