mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup: get a ref to source csses when migrating
Date: Mon, 24 Aug 2015 14:45:07 -0400	[thread overview]
Message-ID: <20150824184507.GB28944@mtj.duckdns.org> (raw)
In-Reply-To: <1440335432-4202-2-git-send-email-cyphar@cyphar.com>

On Sun, Aug 23, 2015 at 11:10:31PM +1000, Aleksa Sarai wrote:
> Grab a ref to each source css being migrated from, otherwise it's
> possible for the refcount to reach zero between ->can_attach() and
> ->cancel_attach(). This means that operations on the task's old css
> (such as container_of(...)) become unsafe, as we may be operating on a
> different css.
> 
> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> ---
>  kernel/cgroup.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 4ec1b7ee5de8..6cbfbe36284d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -2305,6 +2305,17 @@ static int cgroup_migrate(struct cgroup *cgrp, struct task_struct *leader,
>  	if (list_empty(&tset.src_csets))
>  		return 0;
>  
> +	/*
> +	 * Fetch a ref of each css, so that the old task's css doesn't get reaped
> +	 * between ->can_attach() and ->cancel_attach().
> +	 */
> +	down_read(&css_set_rwsem);
> +	list_for_each_entry(cset, &tset.src_csets, mg_node) {
> +		for_each_e_css(css, i, cgrp)
> +			css_get(cset->subsys[i]);
> +	}
> +	up_read(&css_set_rwsem);

Have you verified that the scenario you're describing can actually
happen?  AFAICS, cgroup_migrate_add_src() already does the pinning.

Thanks.

-- 
tejun

  reply	other threads:[~2015-08-24 18:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 12:24 Bad Reference Semantics in PIDs Controller Aleksa Sarai
2015-08-23 13:10 ` [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai
2015-08-23 13:10   ` [PATCH 1/2] cgroup: get a ref to source csses when migrating Aleksa Sarai
2015-08-24 18:45     ` Tejun Heo [this message]
2015-08-25  2:00       ` Aleksa Sarai
2015-08-25 18:14         ` Tejun Heo
2015-08-23 13:10   ` [PATCH 2/2] cgroup: pids: fix invalid get/put usage Aleksa Sarai
2015-08-24 19:00     ` Tejun Heo
2015-08-23 13:13   ` [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150824184507.GB28944@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®