From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly
Date: Mon, 24 Aug 2015 15:52:46 -0700 [thread overview]
Message-ID: <20150824225105.GA8056@jaegeuk-mac02.mot.com> (raw)
In-Reply-To: <20150824165423.GC2837@jaegeuk-mac02.mot-mobility.com>
Hi Chao,
On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote:
> On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote:
> > In following call stack, if unfortunately we lose all chances to truncate
> > inode page in remove_inode_page, eventually we will add the nid allocated
> > previously into free nid cache, this nid is with NID_NEW status and with
> > NEW_ADDR in its blkaddr pointer:
> >
> > - f2fs_create
> > - f2fs_add_link
> > - __f2fs_add_link
> > - init_inode_metadata
> > - new_inode_page
> > - new_node_page
> > - set_node_addr(, NEW_ADDR)
> > - f2fs_init_acl failed
> > - remove_inode_page failed
> > - handle_failed_inode
> > - remove_inode_page failed
> > - iput
> > - f2fs_evict_inode
> > - remove_inode_page failed
> > - alloc_nid_failed cache a nid with valid blkaddr: NEW_ADDR
Unfortunately, this couldn't fix my bug case.
I'm still struggling to find out something tho.
Meanwhile, let's stay with both of the patches.
Thanks,
next prev parent reply other threads:[~2015-08-24 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 9:40 Chao Yu
2015-08-24 16:54 ` Jaegeuk Kim
2015-08-24 22:52 ` Jaegeuk Kim [this message]
2015-08-25 6:38 ` [f2fs-dev] " Chao Yu
2015-08-25 22:40 ` Jaegeuk Kim
2015-08-26 12:46 ` Chao Yu
2015-08-25 1:39 ` Chao Yu
2015-08-25 22:17 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824225105.GA8056@jaegeuk-mac02.mot.com \
--to=jaegeuk@kernel.org \
--cc=chao2.yu@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®