From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbbHYG7k (ORCPT ); Tue, 25 Aug 2015 02:59:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:40944 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbbHYG7i (ORCPT ); Tue, 25 Aug 2015 02:59:38 -0400 Date: Tue, 25 Aug 2015 08:59:32 +0200 From: Michal Kubecek To: Chen-Yu Tsai Cc: Stephen Boyd , Michael Turquette , linux-clk , linux-kernel , stable@vger.kernel.org Subject: Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h Message-ID: <20150825065932.GA29101@unicorn.suse.cz> References: <1439882205-10978-1-git-send-email-wens@csie.org> <20150824212828.GD14330@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote: > On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd wrote: > > On 08/18, Chen-Yu Tsai wrote: > >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not > >> include its definition. > >> > >> This results in a compile error when only clk-conf.h is used. > >> > >> Signed-off-by: Chen-Yu Tsai > >> Cc: stable@vger.kernel.org > > > > Why is stable Cc-ed? Is there some sort of compilation failure on > > stable kernels? > > There isn't for now. Though I don't see why we shouldn't fix this for > stable kernels as well. It's possible other people or third-party > vendors working with stable/LTS kernels (Android?) may run into it. How about - It must fix a real bug that bothers people (not a, "This could be a problem..." type thing). in Documentation/stable_kernel_rules.txt? Michal Kubecek