From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbbHYIY6 (ORCPT ); Tue, 25 Aug 2015 04:24:58 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:56275 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755137AbbHYIYh (ORCPT ); Tue, 25 Aug 2015 04:24:37 -0400 X-Helo: d06dlp02.portsmouth.uk.ibm.com X-MailFrom: cornelia.huck@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 25 Aug 2015 10:20:18 +0200 From: Cornelia Huck To: Jason Wang Cc: gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" Subject: Re: [PATCH V2 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses Message-ID: <20150825102018.0b32b9bd.cornelia.huck@de.ibm.com> In-Reply-To: <1440488835-4388-2-git-send-email-jasowang@redhat.com> References: <1440488835-4388-1-git-send-email-jasowang@redhat.com> <1440488835-4388-2-git-send-email-jasowang@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15082508-0009-0000-0000-0000054EBC03 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2015 15:47:14 +0800 Jason Wang wrote: > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index 9ff4193..95f2901 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -762,13 +762,15 @@ ioeventfd_check_collision(struct kvm *kvm, struct _ioeventfd *p) > return false; > } > > -static enum kvm_bus ioeventfd_bus_from_flags(__u32 flags) > +static enum kvm_bus ioeventfd_bus_from_flags(struct kvm_ioeventfd *args) ioeventfd_bus_from_args()? But _from_flags() is not wrong either :) > { > - if (flags & KVM_IOEVENTFD_FLAG_PIO) > + if (args->flags & KVM_IOEVENTFD_FLAG_PIO) > return KVM_PIO_BUS; > - if (flags & KVM_IOEVENTFD_FLAG_VIRTIO_CCW_NOTIFY) > + if (args->flags & KVM_IOEVENTFD_FLAG_VIRTIO_CCW_NOTIFY) > return KVM_VIRTIO_CCW_NOTIFY_BUS; > - return KVM_MMIO_BUS; > + if (args->len) > + return KVM_MMIO_BUS; > + return KVM_FAST_MMIO_BUS; Hm... /* When length is ignored, MMIO is put on a separate bus, for * faster lookups. */ return args->len ? KVM_MMIO_BUS : KVM_FAST_MMIO_BUS; > } > > static int This version of the patch looks nice and compact. Regardless whether you want to follow my (minor) style suggestions, consider this patch Acked-by: Cornelia Huck