From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org
Subject: Re: xtensa build failures in -next due to DMA API changes
Date: Tue, 25 Aug 2015 13:21:40 -0700 [thread overview]
Message-ID: <20150825202140.GB25409@roeck-us.net> (raw)
In-Reply-To: <20150825201532.GA24940@lst.de>
Hi Christoph,
On Tue, Aug 25, 2015 at 10:15:32PM +0200, Christoph Hellwig wrote:
> Hi Guenter,
>
> > The problem seems to have been introduced with changes made by Christoph
> > Hellwig, coming in through Andrew's tree. Copying them here for comments.
>
> xtensa doesn't use the generic dma map implementation, so it shouldn't
> include dma-mapping-common.h anywhere, and in my tree it doesn't.
>
> Can you do a git-grep for dma-mapping-common.h on the tree that you
> see this error on? Nothing but arch/*/include/asm/dma-mapping.h should
> include it. In my tree it's all fine:
>
I also see
arch/xtensa/include/asm/dma-mapping.h:#include <asm-generic/dma-mapping-common.h>
It looks like there is a conflict with "xtensa: reimplement DMA API using common
helpers" by Max Filippov, which added the include. This patch is in -next.
Guenter
next prev parent reply other threads:[~2015-08-25 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 20:07 Guenter Roeck
2015-08-25 20:15 ` Christoph Hellwig
2015-08-25 20:21 ` Guenter Roeck [this message]
2015-08-25 20:24 ` Christoph Hellwig
2015-08-26 7:53 ` Max Filippov
2015-08-26 7:59 ` Andrew Morton
2015-08-26 17:53 ` Chris Zankel
2015-08-26 17:41 ` Christoph Hellwig
2015-09-01 0:35 ` Chris Zankel
2015-08-25 20:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825202140.GB25409@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=hch@lst.de \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®