mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dave Martin <Dave.Martin@arm.com>
Cc: "Christopher Covington" <cov@codeaurora.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Jon Medhurst (Tixy)" <tixy@linaro.org>,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Nicolas Pitre" <nico@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Yingjoe Chen" <yingjoe.chen@mediatek.com>,
	"Wang Nan" <wangnan0@huawei.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Gregory CLEMENT" <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	"Paul Bolle" <pebolle@tiscali.nl>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Nathan Lynch" <nathan_lynch@mentor.com>,
	linux-kernel@vger.kernel.org,
	"Masahiro Yamada" <yamada.m@jp.panasonic.com>,
	"Maxime Coquelin stm32" <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] arm: Handle starting up in secure mode
Date: Wed, 26 Aug 2015 11:48:39 +0100	[thread overview]
Message-ID: <20150826104839.GC21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150826103940.GD6281@e103592.cambridge.arm.com>

On Wed, Aug 26, 2015 at 11:39:42AM +0100, Dave Martin wrote:
> On Mon, Aug 24, 2015 at 09:55:26AM -0400, Christopher Covington wrote:
> > ARM Linux appears to have never been made aware of the ARMv7 security
> > extensions. When CONFIG_ARM_SEC_EXT=y, have it probe for its security
> > state by checking whether CNTFRQ is writeable and potentially make
> > mode changes based on the information. The most features are available
> > from hypervisor (HYP) mode, so switch to it possible. Failing that,
> > prefer non-secure supervisor (SVC) mode to secure supervisor mode.
> 
> Up to now we've steered clear of this, since it's a bit of a fig leaf
> for broken firmware unless Linux actually has some valid use for the
> Security Extensions itself.
> 
> Shouldn't the bootloader or firmware be doing this stuff, and if not,
> why not?
> 
> 
> Some other things that would need to be considered in any case:
> 
>  * SoC-specific setup of the Non-secure view of the system:  This has
>    to happen very early, so making it DT aware is going to be hard --
>    failing that, we are effectively risking bringing back board files.
>    The split in responsibility between firmware/bootloader and kernel
>    needs to be clearly defined and (as far as possible) platform-
>    independent, otherwise we'll have total chaos.
> 
>  * Out of reset, generally the CPU state is only fully defined for the
>    highest exception level.  You probably need to be doing more setup
>    than you're currently doing.
> 
>  * SMP, secondary boot and suspend/resume -- again involving board-
>    specific code.
> 
>  * You need to safely "park" the Secure World before running anything
>    in Non-Secure.  As a minimum, you would need to quiesce any
>    Secure interrupt sources, disable all interrupt traps to Monitor
>    mode, and make sure that the Monitor vectors point somewhere
>    real, so that executing SMC doesn't send the CPU off into the
>    long grass...

Another question is: has this been tested with kexec?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-08-26 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 13:55 Christopher Covington
2015-08-26 10:37 ` Ard Biesheuvel
2015-08-26 10:39 ` Dave Martin
2015-08-26 10:48   ` Russell King - ARM Linux [this message]
2015-08-26 14:19     ` Christopher Covington
2015-08-27 15:28       ` Dave Martin
2015-09-08 13:21   ` Linus Walleij
2015-08-26 10:46 ` Russell King - ARM Linux
2015-08-27 16:17 ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150826104839.GC21084@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Dave.Martin@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=cov@codeaurora.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=keescook@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nathan_lynch@mentor.com \
    --cc=nico@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=sboyd@codeaurora.org \
    --cc=tixy@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wangnan0@huawei.com \
    --cc=will.deacon@arm.com \
    --cc=yamada.m@jp.panasonic.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®