From: Luis de Bethencourt <luis@debethencourt.com>
To: Bin Liu <binmlist@gmail.com>
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: musb: Fix module autoload for OF platform driver
Date: Thu, 27 Aug 2015 17:49:02 +0200 [thread overview]
Message-ID: <20150827154902.GA2117@goodgumbo.baconseed.org> (raw)
In-Reply-To: <CADYTM3b7sUexeZESEE28ohji+7BpBrsoqHAz8H5Z-k-Lcx9ubA@mail.gmail.com>
On Thu, Aug 27, 2015 at 10:41:42AM -0500, Bin Liu wrote:
> Hi,
>
> On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt
> <luis@debethencourt.com> wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
>
> Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'?
> That helps filtering in git-log.
>
> Thanks,
> -Bin.
>
Off course. Sent a second version with 'usb: musb: ux500:' in the commit
subject.
Thanks for reviewing,
Luis
> >
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> > drivers/usb/musb/ux500.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> > index 39168fe..b2685e7 100644
> > --- a/drivers/usb/musb/ux500.c
> > +++ b/drivers/usb/musb/ux500.c
> > @@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
> > {}
> > };
> >
> > +MODULE_DEVICE_TABLE(of, ux500_match);
> > +
> > static struct platform_driver ux500_driver = {
> > .probe = ux500_probe,
> > .remove = ux500_remove,
> > --
> > 2.4.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-08-27 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:07 Luis de Bethencourt
2015-08-27 15:41 ` Bin Liu
2015-08-27 15:49 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827154902.GA2117@goodgumbo.baconseed.org \
--to=luis@debethencourt.com \
--cc=balbi@ti.com \
--cc=binmlist@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®